Repository navigation
feat: add proactive completion handoffs - #27
Conversation
f64c5d2 to
7418af7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f64c5d253c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const metadata = { | ||
| ...existingMetadata, | ||
| ...snapshotMetadata, | ||
| }; |
There was a problem hiding this comment.
Invalidate PR checks when the head changes
When a PR has a successful suite recorded and then receives another commit, this merge preserves the old metadata.checks while pullRequestSnapshot overwrites metadata.head.sha. On the later merged-PR event, autoHeldReasons only reads checks.conclusion, so AUTO_WHEN_SAFE can close an issue using checks from an older SHA. Store the suite SHA and clear or ignore checks whenever head.sha changes before reconciling completion.
Useful? React with 👍 / 👎.
| key={row.id} | ||
| requestId={row.id} | ||
| issueId={row.issue.id} | ||
| canResolve={canRecoverRuns} |
There was a problem hiding this comment.
Preserve watcher access to completion decisions
For completion/recovery rows in Command Center, this passes only the admin-only canRecoverRuns flag into ActionRequestCard. The server ACL still allows issue watchers, and issue assignees are auto-watchers, to accept or decline unassigned action requests, but the card hides both buttons when canResolve is false, so non-admin watchers/assignees see a ready-to-close ask they are allowed to resolve but cannot act on from this surface. Pass a per-row watcher/assignee permission signal or keep the legacy action card for those users.
Useful? React with 👍 / 👎.
Summary
Validation