Skip to content

feat: add proactive completion handoffs - #27

Merged
Codename-11 merged 1 commit into
mainfrom
codex/completion-candidates
Jul 14, 2026
Merged

Codename-11 merged 1 commit into
mainfrom
codex/completion-candidates

Conversation

@Codename-11

Copy link
Copy Markdown
Owner

Summary

  • add workspace/project completion automation policies with safe automatic completion
  • create shared deduplicated actionable completion and PR-recovery cards across dashboard, inbox, command center, and issue activity
  • reconcile native GitHub PR merge/closure and aggregate checks, with a restart-safe worker sweep
  • let terminal agent runs explicitly recommend issue completion while preserving one final comment per run

Validation

  • pnpm lint
  • pnpm typecheck
  • pnpm test (1,244 passed; 1 intentional live-connector skip)
  • pnpm build
  • Playwright: 36/38 on shared disposable DB; both state-contaminated failures passed after clean DB reset (38/38 effective)

@Codename-11
Codename-11 force-pushed the codex/completion-candidates branch from f64c5d2 to 7418af7 Compare July 14, 2026 19:53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f64c5d253c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +202 to +205
const metadata = {
...existingMetadata,
...snapshotMetadata,
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Invalidate PR checks when the head changes

When a PR has a successful suite recorded and then receives another commit, this merge preserves the old metadata.checks while pullRequestSnapshot overwrites metadata.head.sha. On the later merged-PR event, autoHeldReasons only reads checks.conclusion, so AUTO_WHEN_SAFE can close an issue using checks from an older SHA. Store the suite SHA and clear or ignore checks whenever head.sha changes before reconciling completion.

Useful? React with 👍 / 👎.

key={row.id}
requestId={row.id}
issueId={row.issue.id}
canResolve={canRecoverRuns}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve watcher access to completion decisions

For completion/recovery rows in Command Center, this passes only the admin-only canRecoverRuns flag into ActionRequestCard. The server ACL still allows issue watchers, and issue assignees are auto-watchers, to accept or decline unassigned action requests, but the card hides both buttons when canResolve is false, so non-admin watchers/assignees see a ready-to-close ask they are allowed to resolve but cannot act on from this surface. Pass a per-row watcher/assignee permission signal or keep the legacy action card for those users.

Useful? React with 👍 / 👎.

@Codename-11
Codename-11 merged commit dcddfdd into main Jul 14, 2026
3 checks passed
@Codename-11
Codename-11 deleted the codex/completion-candidates branch July 14, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant