Skip to content

Clarify configuration scopes and ownership - #32

Merged
Codename-11 merged 2 commits into
mainfrom
codex/configuration-ia-audit
Jul 15, 2026
Merged

Codename-11 merged 2 commits into
mainfrom
codex/configuration-ia-audit

Conversation

@Codename-11

Copy link
Copy Markdown
Owner

What changed

  • adds a screenshot-first, route-by-route audit of configuration ownership across Personal, Workspace, Instance Administration, and Mission Control as Operations
  • introduces explicit scope labels and a Personal settings overview, and makes workspace settings name the active tenant
  • moves instance authentication into the Instance Administration shell while preserving /settings/auth as a redirect
  • makes workspace API access and developer clients canonical workspace routes
  • makes dispatch fall-through settings editable and persists their effective workspace value
  • improves settings navigation on mobile, current-page semantics, Activity preference keyboard behavior, and runtime card layout

Why

Configuration controls were split across shells with overlapping names and unclear ownership. Instance-wide authentication appeared under Account settings, workspace credentials appeared personal, Mission Control preferences read like another settings area, and dispatch defaults explained a value that could not be changed at the authoritative surface.

This change establishes four visible layers: Personal, named Workspace, Instance, and Mission Control as Operations. It preserves the existing Forge visual language and deep links while documenting the larger migration backlog.

Evidence

The audit inventory, walkthrough health report, screenshots index, target sitemap, role model, migration plan, and P0/P1/P2 backlog are in docs/audits/settings-information-architecture-2026-07-14/.

Validation

  • pnpm lint (passes with existing native-select/type-import warnings)
  • pnpm typecheck
  • focused workspace router tests: 21/21
  • complete serial Vitest suite: 1,264 passed, 1 skipped
  • complete Playwright suite: 39/39
  • production build through the Playwright web-server flow
  • desktop and mobile before/after screenshots captured and inspected

@Codename-11
Codename-11 merged commit bb2d161 into main Jul 15, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12f758a1a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +72 to +74
event.preventDefault();
setOpen(false);
buttonRef.current?.focus();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Stop Escape from collapsing Activity behind the dialog

When the Activity preferences dialog is open while the Activity shelf is expanded, pressing Escape runs this new handler but the same key event can still reach the existing shelf-level Escape hotkey in mission-control.tsx that collapses the panel to the pill. Since this handler only calls preventDefault() and the hotkey helper does not ignore handled events, keyboard users lose the Activity context instead of just closing the preferences dialog; stop the event from reaching the shelf hotkey or make that hotkey ignore already-handled events.

Useful? React with 👍 / 👎.

@Codename-11 Codename-11 mentioned this pull request Jul 15, 2026
@Codename-11
Codename-11 deleted the codex/configuration-ia-audit branch July 15, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant