Repository navigation
fix(android): request include_compacted on session message loads - #709
Conversation
|
🤖 Hermes-Relay automated PR intake Thanks for addressing compacted session scrollback on Android! This targets The reported hygiene scan and device observation are useful context, but the reopen observation used a changed server default rather than this client flag. Please add the device/emulator and server version details, and either verification of this PR's client against a server default that excludes compacted messages or an explicit note that this check remains outstanding. A maintainer will review the verification gap and implementation; this automated intake does not establish code correctness. |
86b5a27 to
11780bc
Compare
|
Rebased onto current
Ready for review when CI finishes on the new head. |
Hermes in-place compaction archives older turns under the same session. Without include_compacted=true, reopen only showed the summary and short active tail. Always pass the flag on Dashboard and Hermes API message pagination so scrollback matches stored display history.
11780bc to
1f15c64
Compare
Summary
Hermes in-place compaction archives older turns under the same session id (
compacted=1). Android session message loads only sentlimit/offset/order, so reopen depended on the server default (historically false) and could show only the compaction summary plus a short active tail. Always requestinclude_compacted=trueon Dashboard and Hermes API message pagination so user-visible scrollback matches stored display history.Changes
HermesApiClient.getMessages— addinclude_compacted=truequery parameterDashboardApiClient.getSessionMessages— addinclude_compacted=truequery parameterCHANGELOG.md— Unreleased fixed entryVerification
local-stack.sh hygiene-scanclean vsupstream/devScreenshots
No visual change (same transcript UI; more history rows when compacted archive exists).
Compatibility / risk
include_compacted(already present). Harmless if ignored by older servers.Lineage / contributor credit
Checklist
dev, unless this is adev→mainrelease PR or a focused production-tag hotfix PR tomainCHANGELOG.mdis updated for user-visible changes