Skip to content

fix(android): disable sessions drawer swipe-to-open - #738

Open
ophirhan wants to merge 1 commit into
Codename-11:devfrom
ophirhan:fix/drawer-no-swipe-open
Open

ophirhan wants to merge 1 commit into
Codename-11:devfrom
ophirhan:fix/drawer-no-swipe-open

Conversation

@ophirhan

Copy link
Copy Markdown
Contributor

Summary

Sessions drawer edge-swipe to open fights horizontal pans in chat (tables, code, long lines). Disable swipe-to-open; keep the hamburger / explicit open affordance.

Changes

  • SessionDrawer / ChatScreen: drawer gestures disabled for open-from-edge
  • Unit coverage in SessionSidebarLayoutResolverTest for the layout/gesture contract
  • CHANGELOG Unreleased fixed bullet

Test plan

  • Unit test updated
  • On device: horizontal scroll in chat no longer opens the sessions drawer; hamburger still opens it

Compatibility / rollback

Android-only UI gesture change. Revert the commit to restore edge swipe.


Summary

Changes

Verification

Screenshots

Compatibility / risk

Lineage / contributor credit

  • Source PR(s): N/A
  • Attribution preserved by: N/A

Checklist

  • Target branch is dev, unless this is a dev → main release PR or a focused production-tag hotfix PR to main
  • Scope is focused and related issues/PRs are linked
  • Android changes: lint and focused tests ran, or rationale is listed above
  • Translation changes: locale validation/review ran, or N/A is listed above
  • Server/plugin changes: focused tests ran, or N/A/rationale is listed above
  • Desktop changes: build/tests ran, or N/A/rationale is listed above
  • Docs/site changes: build or link/route checks ran, or N/A/rationale is listed above
  • UI changes were tested on a relevant device/emulator/desktop surface, or the missing proof is stated above
  • Commit messages follow Conventional Commits
  • CHANGELOG.md is updated for user-visible changes, or N/A is listed above
  • Public writing hygiene checked: no secrets, private infrastructure, personal names, or AI/process narration
  • Salvaged/replacement work links source PRs and preserves contributor authorship, or N/A is listed above

@hermes-relay-triage hermes-relay-triage Bot added area:android Kotlin app needs-maintainer-review Automated triage exhausted; needs a human labels Oct 18, 2026
@hermes-relay-triage

Copy link
Copy Markdown

🤖 Hermes-Relay automated PR intake

Thanks for the sessions-drawer change!

This is a focused Android PR against dev. The opening writeup says edge-swipe to open is disabled so horizontal pans in chat (tables, code, long lines) no longer open the sessions drawer, while the hamburger still does. Paths match that scope: SessionDrawer, ChatScreen, SessionSidebarLayoutResolverTest, and a CHANGELOG Unreleased bullet. You noted Android-only rollback by reverting the commit. The Test plan marks the unit test as updated and leaves the on-device check unchecked. That is proof not provided, not a failed result. Required checks were still running at intake, so this note does not treat them as passed or failed.

The canonical template under that writeup is still the empty placeholder. Smallest gaps:

  • Put the test notes under ## Verification, with the exact unit-test command and result, or say the command was not run. Keep the on-device check explicitly outstanding.
  • This is a UI gesture change. Under ## Screenshots, add device or emulator details and what you tried, or state that visual proof is still outstanding.
  • Fill ## Compatibility / risk from the rollback note. Check the checklist items that are already true (target dev, CHANGELOG, conventional commit) and mark translation, server, desktop, and docs N/A in the body. Link a related issue if one exists, or note that there isn't one.

A maintainer will review the gesture change once that intake evidence is filled in. This pass does not review implementation correctness.

@github-actions

Copy link
Copy Markdown
Contributor

Review candidate unavailable

The build for PR #738 head ddc196fb0dd2 completed with cancelled and did not publish a candidate bundle.

View workflow run

@ophirhan

Copy link
Copy Markdown
Contributor Author

Required checks are green on ddc196fb (lint, build, test, Required checks). Edge-swipe open is off; the hamburger still opens the sessions drawer. Ready for review when you have bandwidth.

Material3 ModalNavigationDrawer has no edge-width API, so swipe-to-open
steals horizontal pans from markdown code blocks and tables. Keep drawer
gestures off while closed (hamburger still opens); keep swipe-to-close
and scrim dismiss while open.
@ophirhan
ophirhan force-pushed the fix/drawer-no-swipe-open branch from ddc196f to ee81a71 Compare October 19, 2026 16:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:android Kotlin app needs-maintainer-review Automated triage exhausted; needs a human

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant