Skip to content

fix(desktop): preserve strict device identity on current dev - #761

Merged
Codename-11 merged 3 commits into
devfrom
fix/desktop-strict-id-730-review
Oct 19, 2026
Merged

Codename-11 merged 3 commits into
devfrom
fix/desktop-strict-id-730-review

Conversation

@Codename-11

@Codename-11 Codename-11 commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

Keep an explicitly selected Desktop ID from falling back to another computer's name. Retains @Kwentin3's #730 and refreshes it onto dev c459d77 after #759 landed.

Changes

  • Preserve strict authenticated device_id through tool invocation, HTTP dispatch, and socket selection; reject missing, malformed, duplicate, and conflicting identities.
  • Keep the existing friendly device selector and untargeted compatibility path.
  • Retain contributor tests, docs, and CI test selection. Resolve only the changelog conflict with current dev.

Verification

  • Candidate 44a61f4. Plugin code is unchanged from locally verified c7d4e5b; the additional commit merges current dev.
  • python -B -m unittest plugin.tests.test_desktop_strict_id plugin.tests.test_desktop_multidevice plugin.tests.test_desktop_tool_availability plugin.tests.test_desktop_health: 47 passed.
  • git diff --check origin/dev...HEAD and python scripts/check-user-docs-locales.py: passed.
  • Required upstream route source check: all 12 routes present at cc6b1f299bd3a7c0309f003d97dc32014e71fa80.
  • Synthetic WebSocket peers and real loopback HTTP only. No real Desktop commands or installed-runtime checks. Required checks passed on this exact head, including Plugin focused tests, syntax checks, and the public docs build.

Screenshots

No visual change.

Compatibility / risk

Explicit device_id callers now fail closed if the authenticated identity is unavailable. Friendly name selection stays available through device. No protocol migration, client deployment, runtime dependency, or version change.

Lineage / contributor credit

Checklist

  • Target branch is dev, unless this is a dev → main release PR or a focused production-tag hotfix PR to main
  • Scope is focused and related issues/PRs are linked
  • Android changes: lint and focused tests ran, or rationale is listed above
  • Translation changes: locale validation/review ran, or N/A is listed above
  • Server/plugin changes: focused tests ran, or N/A/rationale is listed above
  • Desktop changes: build/tests ran, or N/A/rationale is listed above
  • Docs/site changes: build or link/route checks ran, or N/A/rationale is listed above
  • UI changes were tested on a relevant device/emulator/desktop surface, or the missing proof is stated above
  • Commit messages follow Conventional Commits
  • CHANGELOG.md is updated for user-visible changes, or N/A is listed above
  • Public writing hygiene checked: no secrets, private infrastructure, personal names, or AI/process narration
  • Salvaged/replacement work links source PRs and preserves contributor authorship, or N/A is listed above

@Codename-11
Codename-11 merged commit a6280c0 into dev Oct 19, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant