Skip to content

Prepare package ci/cd pipeline#6

Merged
stesee merged 3 commits into
mainfrom
release-setup
Jun 20, 2026
Merged

Prepare package ci/cd pipeline#6
stesee merged 3 commits into
mainfrom
release-setup

Conversation

@stesee

@stesee stesee commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 20, 2026 17:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the project for publishing via CI/CD by moving build outputs into artifacts/, updating package metadata for a scoped npm package, and extending the GitHub Actions workflow to publish to npm and create GitHub releases.

Changes:

  • Move Rollup outputs (and generated .d.ts) under artifacts/ and stop tracking built/minified files in the repo root.
  • Update docs/examples to reference artifacts/* and the new npm package name @codeuctivity/qr-scanner.
  • Enhance CI workflow to derive a release version, publish to npm with provenance, and attach artifacts to GitHub releases.

Reviewed changes

Copilot reviewed 6 out of 19 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
types/qr-scanner.d.ts Removes tracked root declaration file (now generated into artifacts/types).
rollup.config.js Updates output paths to emit bundles into artifacts/.
README.md Updates installation/setup guidance and artifact paths.
qr-scanner.min.js Removes tracked built bundle from repo root.
qr-scanner.min.js.map Removes tracked source map from repo root.
qr-scanner.umd.min.js Removes tracked UMD bundle from repo root.
qr-scanner.legacy.min.js Removes tracked legacy bundle from repo root.
qr-scanner.legacy.min.js.map Removes tracked legacy source map from repo root.
qr-scanner-worker.min.js Removes tracked worker bundle from repo root.
playwright/fixtures/qr-camera-harness.html Updates integration harness import to artifacts/ bundle path.
demo/index.html Updates demo import to artifacts/ bundle path.
package.json Renames package to scoped name, updates entrypoints/types, adds pack/publish-related scripts and publish config.
package-lock.json Updates lock metadata to match new package name/version.
nimiq_logo_rgb_horizontal.svg Removes sponsor asset no longer referenced by README.
artifacts/.gitkeep Keeps empty artifacts/ directory in git.
.gitignore Ignores generated artifacts/* while keeping .gitkeep.
.github/workflows/build.yml Adds npm publishing (with provenance) and attaches built artifacts to GitHub releases.
Comments suppressed due to low confidence (1)

.github/workflows/build.yml:77

  • The derived npm version uses only GITHUB_RUN_NUMBER for the patch segment. If this workflow run is re-run, GITHUB_RUN_NUMBER stays the same, so npm publish will attempt to publish an already-existing version and the release job will fail. Include GITHUB_RUN_ATTEMPT (or another unique value) in the derived version to make retries publishable (or skip publishing on reruns).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment on lines +22 to 25
"build": "rollup --config && tsc src/qr-scanner.ts --target esnext --module esnext --declaration --declarationDir artifacts/types --emitDeclarationOnly",
"prepack": "npm run build",
"pack:local": "npm pack --pack-destination artifacts",
"test:integration": "playwright test"
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread demo/index.html
Comment on lines 67 to 69
<script type="module">
import QrScanner from "../qr-scanner.min.js";
import QrScanner from "../artifacts/qr-scanner.min.js";

stesee and others added 2 commits June 20, 2026 20:21
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@stesee stesee merged commit 74d8cf6 into main Jun 20, 2026
4 checks passed
@stesee stesee deleted the release-setup branch June 20, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants