fix: use resource-root path for update_project_uids#104
Open
vivienvoid wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resave_resourcesres://so the Godot-side operation stays rooted in the active projectWhy
update_project_uidspreviously passed an absolute host path like/mnt/c/...into the Godot-sideresave_resources()operation. That script prefixes non-resource paths withres://, which turned the path into malformedres:///mnt/...and caused the tool to process zero files while still reporting success.This change keeps the operation rooted in the active project by passing
res://explicitly instead.Verification
npm run build4.6.2.stable.official.71f334935update_project_uidsnow reports:Using project path: res://Found 3 scenesFound 1 scripts/shadersCloses #102