Skip to content

test: Add E2E tests for settings and video meeting pages#38

Closed
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1770112899-add-e2e-tests-for-gaps
Closed

test: Add E2E tests for settings and video meeting pages#38
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1770112899-add-e2e-tests-for-gaps

Conversation

@devin-ai-integration
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot commented Feb 3, 2026

What does this PR do?

Adds E2E test coverage for settings pages and video meeting error states that were identified as gaps in the existing test suite.

New test files:

  • settings-general.e2e.ts - Tests for timezone, time format, and week start settings
  • settings-api-keys.e2e.ts - Tests for API key CRUD operations
  • settings-calendars.e2e.ts - Tests for calendar and conferencing settings pages
  • video-meeting-pages.e2e.ts - Tests for video meeting error states (invalid UID, ended meeting, future meeting)

Test coverage added:

  • Settings/My-Account general settings (4 tests)
  • Settings/Developer API keys management (4 tests)
  • Settings/My-Account calendars and conferencing (6 tests)
  • Video meeting pages error handling (5 tests)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - test files only
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Run the E2E tests locally:

yarn e2e --grep "Settings - General"
yarn e2e --grep "Settings - API Keys"
yarn e2e --grep "Settings - Calendars"
yarn e2e --grep "Video Meeting"

Important review items:

  • Verify data-testid attributes used in tests exist in the actual UI components (e.g., timezone-select, new-api-key-button, api-key-dialog)
  • Verify tRPC endpoint paths match actual implementation
  • Confirm bookings fixture API usage is correct in video meeting tests

Checklist

  • I have read the contributing guide
  • My code follows the style guidelines of this project
  • I have checked if my changes generate no new warnings

Devin session


Open with Devin

- Add settings-general.e2e.ts: Tests for timezone, time format, week start settings
- Add settings-api-keys.e2e.ts: Tests for API key CRUD operations
- Add settings-calendars.e2e.ts: Tests for calendar and conferencing settings pages
- Add video-meeting-pages.e2e.ts: Tests for video meeting error states

These tests address coverage gaps identified in the E2E test analysis:
- Settings/My-Account general settings
- Settings/Developer API keys management
- Settings/My-Account calendars and conferencing
- Video meeting pages (not found, ended, not started)
@devin-ai-integration
Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2026

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Add E2E tests for settings and video meeting pages". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@devin-ai-integration devin-ai-integration Bot changed the title Add E2E tests for settings and video meeting pages test: Add E2E tests for settings and video meeting pages Feb 3, 2026
Copy link
Copy Markdown
Author

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@devin-ai-integration devin-ai-integration Bot deleted the devin/1770112899-add-e2e-tests-for-gaps branch April 24, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants