feat: add PodDisruptionBudget to inventory-service Helm chart#205
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
feat: add PodDisruptionBudget to inventory-service Helm chart#205devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
… monolith - .NET 8 Web API with controllers, services, models, EF Core DbContext - Angular 17 frontend with inventory list and low-stock components - Multi-stage Dockerfile following monolith-iac pattern - Helm chart with deployment, service, network policy, service monitor, HPA - ArgoCD application manifests for dev and staging namespaces - GitHub Actions CI/CD pipeline (build, test, push to ECR) - Unit tests with 9 passing test cases
- Added pdb.yaml template with selector labels - Added pdb.minAvailable: 1 to values.yaml
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
devin-ai-integration
Bot
force-pushed
the
workshop-mason
branch
2 times, most recently
from
833b8a2 to
32d7a79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
PodDisruptionBudgetresource to the inventory-service Helm chart withminAvailable: 1, ensuring at least one pod remains available during voluntary disruptions (node drains, cluster upgrades, etc.).Changes:
templates/pdb.yamlusing existing_helpers.tplfor naming and label consistencypdb.minAvailablevalue invalues.yaml(default:1)Review & Testing Checklist for Human
replicaCount: 1: The default replica count is 1 and minAvailable is 1, which means voluntary disruptions (e.g.kubectl drain) will be blocked. Confirm this is intentional — if not, bumpreplicaCountto ≥2 in values-dev/staging overrideshelm template helm/inventory-service/and confirm the PDB renders correctly with expected name, labels, and selectorpdb.enabledtoggle is needed (other chart resources like HPA use conditional rendering, but the PDB is always created)Notes
decomposition-devanddecomposition-stagingnamespaces — no changes were needed there.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/9fa44dd0da124db48d3429c429bd491b