CI: add review-gate check on pull requests - #268
Merged
Merged
Conversation
matt-manuel
added
the
review-exempt
Member
Author
|
review-exempt: verbatim copy of a centrally reviewed CI workflow; per-repo delta is comments-only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.github/workflows/review-gate.yml— this repo's first GitHub Actions workflow. It's a visible, non-required check that fails when a pull request carries neither anadversarial-reviewednor areview-exemptlabel. It re-runs automatically on label changes and on title edits (e.g. fixing a "DO NOT MERGE" title), and auto-passes dependabot PRs, dependency-bump PRs, drafts, and PRs titled DO NOT MERGE — those never need a human review label.This is deliberately NOT a required check. It makes review status visible at the merge button without ever blocking a merge; whether to make it required is a separate decision for later.
This is a copy of a centrally maintained workflow used across our repos, already reviewed before being rolled out here — see the
review-exemptlabel and the comment on this PR.Note: GitHub Actions is in a major outage today (confirmed via githubstatus.com — the Actions component is showing a major outage). This check will likely first report late or not at all until Actions recovers. Live verification — watching the check fail on an unlabeled PR, then pass once labeled — will happen after recovery, not as part of this PR.