Conversation
Up to standards ✅🟢 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 17 minor |
🟢 Metrics 7 complexity · 0 duplication
Metric Results Complexity 7 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull request overview
This PR extends the MatterCraft Cognitive3D integration to support room capture, fixations, and remote variables by exposing new editor properties, wiring them into the Cognitive3D SDK config, and adding runtime hooks for WebXR geometry features and remote-variable availability.
Changes:
- Added room capture / fixations / remote variables-related editor props and mapped them into the SDK
config. - Added remote variables helpers and an availability event on
Cognitive3DContext. - Patched
navigator.xr.requestSessionto requestplane-detection/mesh-detectionwhen room capture is enabled, and logged granted geometry features at session start.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Cognitive3DContext.ts | Adds context flags plus remote variable access helpers and an availability event. |
| src/Cognitive3D.ts | Adds new construction props, maps them to SDK config, installs geometry-feature request patching, and wires remote-variable availability on session start/dispose. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| roomDataLimit: this.constructorProps.roomDataLimit || 64, | ||
| enableFixation: this.constructorProps.enableFixations !== false, | ||
| allowFixationWithoutEyeTracking: this.constructorProps.allowFixationWithoutEyeTracking === true, | ||
| fixationDataLimit: this.constructorProps.fixationDataLimit || 256, |
| private installGeometryFeatures() { | ||
| const xr = (navigator as any).xr; | ||
| if (!xr || typeof xr.requestSession !== "function" || this._originalRequestSession) { | ||
| return; | ||
| } |
Cognitive3DContext:getRemoteVariable,listRemoteVariables,fetchRemoteVariables,onRemoteVariablesAvailable.plane-detectionandmesh-detectionwhen room capture is on.