Open
Conversation
Contributor
Author
|
edit PR:
|
- provides the "or" case for the components of the 'name' argument
- implementation: add an expression generator 'generate_watch_expr()':
- if 'name' is a vector its elements are parsed to a list of reactives and put inside obeserveEvent()
- if length(name) == 1, the default (previouis) behaviour is used
- style: run styler::style_file("R/funs.R", style = grkstyle::grk_style_transformer)
- updated doc-string
- change stop_if to stop_if_not (see changes to NAMESPACE as well)
- add entry to roxygen which seems to be (?) necessary to make a link to a function in a different package via shiny::observeEvent
- adding the session argument in view of ColinFay#17 and ColinFay#18 - remove redundant whitespace
To make the error message more useful: -> inisde stop_if_not(), the exact events/flags that have not been initiated are printed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3
Add several name-watchers for
on()generate_watch_expr()that parses "name" arg to a list of reactivesobserveEventlength(name) == 1, the default (previouis) behaviour is usedRestyle with
grkstyler.see edb8c82