cypress: add tests for redlining_as_comments#13958
Closed
mohit-marathe wants to merge 3 commits into
Closed
Conversation
mistmist
previously requested changes
Jan 13, 2026
github-project-automation
Bot
moved this from To Review
to In Progress
in Collabora Online
mohit-marathe
force-pushed
the
private/mohitm/redlining-comments-test
branch
from
2517f93 to
8e2304b
Compare
mistmist
dismissed
their stale review
the review was for an older version of the PR, why do i have to manually dismiss this
mistmist
reviewed
Apr 16, 2026
Contributor
mistmist
left a comment
mistmist
left a comment
There was a problem hiding this comment.
don't know how to review the actual cypress tests :)
which sets redlining_as_comments=true in coolwsd config, and run specs in cypress_test/integration_tests/redline Signed-off-by: Mohit Marathe <mohit.marathe@collabora.com> Change-Id: I9072f58a46e761348c0383dc7c262d24d4b43946
Signed-off-by: Mohit Marathe <mohit.marathe@collabora.com> Change-Id: I5fee12c79ba66bec7b772ab194c0688ef78993f5
Signed-off-by: Mohit Marathe <mohit.marathe@collabora.com> Change-Id: Ifaeb83cb4b3d69093ec7a85a487c69152c89a099
mohit-marathe
force-pushed
the
private/mohitm/redlining-comments-test
branch
from
8e2304b to
9f2d95d
Compare
Contributor
Author
|
moved to gerrit: https://gerrit.collaboraoffice.com/c/online/+/2626 |
Contributor
Author
|
moved to gerrit: https://gerrit.collaboraoffice.com/c/online/+/2626 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay