convert fixedtext widget to typescript#15348
Merged
Merged
Conversation
printfdebugging
force-pushed
the
private/printfdebugging/typescript-fixedtext
branch
2 times, most recently
from
7aab458 to
ee7089d
Compare
Contributor
|
hi Sahil can you please solve the conflicts here ? |
Contributor
Author
|
@Darshan-upadhyay1110 yes, building latest core. the mobile test failure is actually related to this patch, so will fix that too. |
printfdebugging
force-pushed
the
private/printfdebugging/typescript-fixedtext
branch
2 times, most recently
from
6a93137 to
a1c5715
Compare
eszkadev
reviewed
Apr 16, 2026
Contributor
|
rebase needed |
Signed-off-by: Sahil Gautam <sahil.gautam@collabora.com> Change-Id: I9fe501700e2145cfb54b3850a3437e1ddba7698a
Signed-off-by: Sahil Gautam <sahil.gautam@collabora.com> Change-Id: Ice04047e314be4558909ac45a1dc709112226a26
Signed-off-by: Sahil Gautam <sahil.gautam@collabora.com> Change-Id: I7154e3551e573889cb7c1b39e062bdf1c34e620a
Without this, it throws warning to the console and the widget is not constructed. Signed-off-by: Sahil Gautam <sahil.gautam@collabora.com> Change-Id: Ie1447753a6212616c67a3a2fecde6010d4d57181
printfdebugging
force-pushed
the
private/printfdebugging/typescript-fixedtext
branch
from
a1c5715 to
7729186
Compare
eszkadev
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay