Private/rparth07/a11y issues fix#15669
Closed
rparth07 wants to merge 4 commits into
Closed
Conversation
The page-level table of contents wrapped each jump link in <h2>, making each navigation entry register as a heading. This polluted the heading outline. Wrap the TOC in <nav><ul> with <li> entries (a standard navigation list of links). Keep the existing toc-h2 / toc-h3 / m-v-0 / link-section classes on the <li> elements so the style and doctype-aware show/hide logic keeps working unchanged. Strip default <ul> styling so the visual result matches the previous design. Update resetFilterResults to also show the new <nav> so the TOC reappears after clearing the search field. Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I6a6bc66e82ca45ac92bf4e4030f562ae52fc13d6
The jsdialog titlebar renders the dialog title as <h2>, then the help template's inner page heading was an <h1>. The DOM heading outline therefore jumped from H2 (dialog title) back up to H1 (inner page), inverting the document outline. Demote the inner page heading to <h2> so it sits at the same level as the framework-supplied dialog title. The remaining content hierarchy (H3 sections, H4 sub-sections) stays unchanged, leaving a sequential H2 -> H2 -> H3 -> H4 outline with no reversals. Update the centering rule in helpdialog.css to also target the new <h2 class="help-dialog-header"> so the visible layout is unchanged. Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I6191fe5bed168c0fe765c63c0e93d86b7bd2ed33
Clicking a jump link in the help TOC made the dialog's close button disappear. The .scroll-button click handler tried to read button.dataset.target, but the HTML uses href="#nnn" - so the handler was a silent no-op and the browser performed its default anchor navigation. That scroll walks every scrollable ancestor, including the modal popup itself (which has overflow:auto in jsdialogs.css), so the dialog's titlebar - and the close button it contains - scrolled off the top. Read href instead, preventDefault, and adjust scrollTop on the .ui-dialog-content container only. The modal stays put, only the help body scrolls, and the close button remains visible. Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: Ia6c0d85631c90b241f12aacaf7b64aa29d7f0672
The TOC jump-link styling explicitly removed the focus outline with "outline: none" and provided no replacement. Keyboard users got no visible cue when stepping through the TOC, breaking WCAG 2.4.7 (Focus Visible). Replace the suppression with "outline: 2px solid var(--color-primary)" plus a 2px outline-offset, matching the focus style used elsewhere in the dialog framework. The CSS variable adapts to light/dark theme. Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I393477a4391bfe3ff3dda4662fb3d52d6e37118d
|
Thank you for your contribution! However, the main branch on GitHub is not used for this project. Please submit patches to the main branch of the online repo at https://gerrit.collaboraoffice.com. See CONTRIBUTING.md for details. This PR has been automatically closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay