Show drag preview of charts in Writer#15697
Closed
GulsahKose wants to merge 1 commit into
Closed
Conversation
Until now MouseControl / ShapeHandlesSection's semi-transparent drag preview worked for charts in Calc and Impress but not in Writer: charts there are wrapped in a Writer fly (type 601) without an isWriterGraphic flag, so the type == 601 && !isWriterGraphic "isFrame" guard suppressed the rendershapeselection request and the preview never had an SVG to show. Drop the guard. Together with the writer_svg_Export change that makes selected charts render as SVG, and the sfxbasemodel guard that keeps an internal render failure from popping up as a user-facing "Document cannot be exported" dialog, charts in Writer now show the same drag preview as in Calc / Impress. Plain Writer text frames (the case the workaround was originally added for, tdf#123874) still behave the same way for the user: the kit returns 0 bytes, no shapeselectioncontent message is sent, no preview, no dialog. Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Change-Id: I2952c6d96c91b49e8fc0f3800cdd02a1fe514dd5
|
Thank you for your contribution! However, the main branch on GitHub is not used for this project. Please submit patches to the main branch of the online repo at https://gerrit.collaboraoffice.com. See CONTRIBUTING.md for details. This PR has been automatically closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now MouseControl / ShapeHandlesSection's semi-transparent drag
preview worked for charts in Calc and Impress but not in Writer:
charts there are wrapped in a Writer fly (type 601) without an
isWriterGraphic flag, so the type == 601 && !isWriterGraphic
"isFrame" guard suppressed the rendershapeselection request and the
preview never had an SVG to show.
Drop the guard. Together with the writer_svg_Export change that
makes selected charts render as SVG, and the sfxbasemodel guard that
keeps an internal render failure from popping up as a user-facing
"Document cannot be exported" dialog, charts in Writer now show the
same drag preview as in Calc / Impress. Plain Writer text frames
(the case the workaround was originally added for, tdf#123874) still
behave the same way for the user: the kit returns 0 bytes, no
shapeselectioncontent message is sent, no preview, no dialog.
Change-Id: I2952c6d96c91b49e8fc0f3800cdd02a1fe514dd5
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay