jsdialog: client-rendered customwidget framework + CSV grid#15708
Closed
shardulvs wants to merge 1 commit into
Closed
jsdialog: client-rendered customwidget framework + CSV grid#15708shardulvs wants to merge 1 commit into
shardulvs wants to merge 1 commit into
Conversation
Add JSDialog.customWidget, a generic dispatcher for widgets the server
emits as { type: 'customwidget', customType, data }. Handlers register
through JSDialog.registerCustomWidgetHandler and own both their
rendering and event dispatch back to the server. This lets a widget
render natively in the client instead of rendering it on the core first
and tunneling it to the client.
Add Widget.CsvGrid: the client side of the rewritten ScCsvGrid in core.
It draws the ruler and the data preview as a single widget, handles the
column-type popup locally, and sends column selection, column-type and
split-toggle events back to the server.
Signed-off-by: Shardul Vikram Singh <shardul.singh@collabora.com>
Change-Id: I1b9f25e6d3efcbe461e4e9311706f5cfad1da478
|
Thank you for your contribution! However, the main branch on GitHub is not used for this project. Please submit patches to the main branch of the online repo at https://gerrit.collaboraoffice.com. See CONTRIBUTING.md for details. This PR has been automatically closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add JSDialog.customWidget, a generic dispatcher for widgets the server emits as { type: 'customwidget', customType, data }. Handlers register through JSDialog.registerCustomWidgetHandler and own both their rendering and event dispatch back to the server. This lets a widget render natively in the client instead of rendering it on the core first and tunneling it to the client.
Add Widget.CsvGrid: the client side of the rewritten ScCsvGrid in core. It draws the ruler and the data preview as a single widget, handles the column-type popup locally, and sends column selection, column-type and split-toggle events back to the server.
Change-Id: I1b9f25e6d3efcbe461e4e9311706f5cfad1da478
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay