Writer: Starting selection from a commented portion of text is not po…#15762
Open
gokaysatir wants to merge 1 commit into
Open
Writer: Starting selection from a commented portion of text is not po…#15762gokaysatir wants to merge 1 commit into
gokaysatir wants to merge 1 commit into
Conversation
gokaysatir
force-pushed
the
private/gokay/backport
branch
from
4a64c16 to
424c51f
Compare
…ssible. Issue: Because comment section handles the events. Fix: Redirect the dragging actions to mouse controller. It doesn't interfere with other comment section actions because it doesn't handle dragging currently. Also a test is added and fix is confirmed. Backport of: https://gerrit.collaboraoffice.com/c/online/+/2360 Signed-off-by: Gökay Şatır <gokay.satir@collabora.com> Change-Id: Ic51cf14ed84a5af4683219fef1a9ddff069824d9
gokaysatir
force-pushed
the
private/gokay/backport
branch
from
424c51f to
f8a40a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ssible.
Issue: Because comment section handles the events.
Fix: Redirect the dragging actions to mouse controller. It doesn't interfere with other comment section actions because it doesn't handle dragging currently.
Also a test is added and fix is confirmed.
Backport of: https://gerrit.collaboraoffice.com/c/online/+/2360
Change-Id: Ic51cf14ed84a5af4683219fef1a9ddff069824d9
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay