Writer: Fix double issuing of paste command.#15763
Merged
Merged
Conversation
gokaysatir
force-pushed
the
private/gokay/backport-2
branch
from
1356e46 to
b1acfaa
Compare
Contributor
Author
|
Sorry for adding both, this may be urgent for the release.
In case it is urgent, it may be plausible to merge this one. |
Issue: Right click paste option triggers 2 different paths. A guards is added. Added a test and also confirmed the test. Backport of: https://gerrit.collaboraoffice.com/c/online/+/2370 Signed-off-by: Gökay Şatır <gokay.satir@collabora.com> Change-Id: I51638dba9e8d48200eb0420536286a40a992d229
gokaysatir
force-pushed
the
private/gokay/backport-2
branch
from
b1acfaa to
86f0b78
Compare
vmiklos
approved these changes
May 15, 2026
Contributor
vmiklos
left a comment
vmiklos
left a comment
There was a problem hiding this comment.
Looks like a correct backport, thanks.
Nit: you didn't manage to keep the change-id unchanged: the gerrit one is Ieaf0bad63c6321aeae53ae00b979830dad90ffb8, this backport has I51638dba9e8d48200eb0420536286a40a992d229. Please keep that unchanged the next time you backport something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Right click paste option triggers 2 different paths. A guards is added.
Added a test and also confirmed the test.
Backport of: https://gerrit.collaboraoffice.com/c/online/+/2370
Change-Id: I51638dba9e8d48200eb0420536286a40a992d229
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay