comments: unresolve thread only if all is resolved#15766
Merged
JaumePujantell merged 1 commit intoMay 15, 2026
Conversation
JaumePujantell
force-pushed
the
private/jaume/comments-backport
branch
2 times, most recently
from
151371a to
29416f3
Compare
Right now the "Unresolve Thread" option appears even if only some comments in a thread are resolved, but the internal UNO call resolves the thread (as it should). This change fixes the label so that it corresponds to the correct action. A cypress test is also added. Signed-off-by: Jaume Pujantell <jaume.pujantell@collabora.com> Change-Id: I4867d44b76357d5c1af66efec3973c455abb77bf (cherry picked from commit 4b4b1bac99853415f5b367197b6fba827f0a958b)
vmiklos
force-pushed
the
private/jaume/comments-backport
branch
from
29416f3 to
a99516b
Compare
vmiklos
approved these changes
May 15, 2026
Contributor
vmiklos
left a comment
vmiklos
left a comment
There was a problem hiding this comment.
Looks like a correct backport, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the "Unresolve Thread" option appears even if only some
comments in a thread are resolved, but the internal UNO call resolves
the thread (as it should). This change fixes the label so that it
corresponds to the correct action. A cypress test is also added.
Signed-off-by: Jaume Pujantell jaume.pujantell@collabora.com
Change-Id: I4867d44b76357d5c1af66efec3973c455abb77bf
(cherry picked from commit 4b4b1bac99853415f5b367197b6fba827f0a958b)