fix(calc): Make dropdows work with different zooms (backport 25.04)#15772
Open
eszkadev wants to merge 1 commit into
Open
fix(calc): Make dropdows work with different zooms (backport 25.04)#15772eszkadev wants to merge 1 commit into
eszkadev wants to merge 1 commit into
Conversation
In I4cab2546f6828ab3c76ba8a4e06601904a06502e, DropDownSection was moved into its own file. During this move, some stuff was broken so the dropdown was only active on part of the dropdown arrow. In I6a5b26b42e4cf77a070452042d5f7a242e874bc0, we then stopped using the uno command to send the dropdown to core, and instead relied on the core position of the dropdown arrow. Finally, Ib48f7266f7b0d147761eaccd647caf39df0d6550 made it so we would click in the center of the dropdown arrow. Unfortunately, Ib48f7266f7b0d147761eaccd647caf39df0d6550 made the problem worse on certain zooms/high DPI screens. The dropdown would then either be activeateable across the whole arrow or not be activateable at all. I think the problems caused by I4cab2546f6828ab3c76ba8a4e06601904a06502e are not still around today, however they did mask problems caused by I6a5b26b42e4cf77a070452042d5f7a242e874bc0 which made the dropdown break when the core position didn't line up. To fix this, we can revert to using the original uno-command-based approach to handling dropdowns. I've chatted to Gokay and he has OKed this as an approach... Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Change-Id: I8973fa6d2caa5558dd4c9d6c52c4cd126a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #15459
In I4cab2546f6828ab3c76ba8a4e06601904a06502e, DropDownSection was moved into its own file. During this move, some stuff was broken so the dropdown was only active on part of the dropdown arrow.
In I6a5b26b42e4cf77a070452042d5f7a242e874bc0, we then stopped using the uno command to send the dropdown to core, and instead relied on the core position of the dropdown arrow.
Finally, Ib48f7266f7b0d147761eaccd647caf39df0d6550 made it so we would click in the center of the dropdown arrow.
Unfortunately, Ib48f7266f7b0d147761eaccd647caf39df0d6550 made the problem worse on certain zooms/high DPI screens. The dropdown would then either be activeateable across the whole arrow or not be activateable at all.
I think the problems caused by I4cab2546f6828ab3c76ba8a4e06601904a06502e are not still around today, however they did mask problems caused by I6a5b26b42e4cf77a070452042d5f7a242e874bc0 which made the dropdown break when the core position didn't line up.
To fix this, we can revert to using the original uno-command-based approach to handling dropdowns. I've chatted to Gokay and he has OKed this as an approach...