Conversation
Tamir198
requested changes
Dec 8, 2025
| numberButtons.forEach(btn => { | ||
| btn.addEventListener("click", () => { | ||
| if (operator) { | ||
| if (y!==undefined){ |
| btn.addEventListener("click", () => { | ||
| if (operator) { | ||
| if (y!==undefined){ | ||
| y = y*10+ +btn.textContent |
| } | ||
| else{ | ||
| y = +btn.textContent | ||
| addNumberToDisplay(btn.textContent) |
Member
There was a problem hiding this comment.
You can extract your main if and else code blocks into functions
| addNumberToDisplay('+') | ||
| }) | ||
|
|
||
| subtract.addEventListener('click', function () { |
Member
There was a problem hiding this comment.
Can you think of a way to only call 1 event listener for all of actions?
| equal.addEventListener('click', function () { | ||
| if (operator == '+') { | ||
| result = x + y; | ||
| display.textContent = result; |
Member
There was a problem hiding this comment.
I would use if else in here to prevent all those checks, also this line is being called no matter what so you dont need to write it in every line
Member
There was a problem hiding this comment.
If you have code that looks like this :
if(condition)
if(secondCondition)
........more checks
........even more checksJs will read every if statement, unless you will have a return.
But with else if it will only read the relevant none fulfilled condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.