finish js#15
Open
RazBenLulu wants to merge 1 commit into
Open
Conversation
Tamir198
requested changes
Dec 8, 2025
| @@ -0,0 +1,96 @@ | |||
| const number = document.querySelectorAll(".number") | |||
|
|
||
| number.forEach(button => { | ||
| button.addEventListener('click', function () { | ||
| console.log(button.textContent) |
Member
There was a problem hiding this comment.
Remove the console, its not needed
| const op = [add, sub, mul, div] | ||
| let operation = "" | ||
|
|
||
| op.forEach(button => { |
Member
There was a problem hiding this comment.
good practice on the array and single event listener
| }) | ||
|
|
||
| eql.addEventListener('click', function () { | ||
| if (input === "" && x === "") { |
Member
There was a problem hiding this comment.
You could extract this check into a function because you have this many times in the code
| } | ||
|
|
||
| y = input | ||
| num1 = Number(x) |
Member
There was a problem hiding this comment.
Add a check to see that this will not be NAN by accident
| } | ||
| } | ||
|
|
||
| if (sum=="Error"){ |
Member
There was a problem hiding this comment.
Hardcoded strings should be saves inside constant variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.