Elad abutbul calcualtor#16
Open
Elad-Abutbul wants to merge 2 commits into
Open
Conversation
Tamir198
requested changes
Dec 8, 2025
| let firstNum = 0; | ||
| let secondNumb = 0; | ||
| let operator = null; | ||
| let bool = true; |
Member
There was a problem hiding this comment.
Can you give this more meaningful name? what is the roll of this bool?
|
|
||
| buttons.addEventListener("click", (e) => { | ||
| const el = e.target; | ||
| if (el.tagName !== "BUTTON") return; |
Member
There was a problem hiding this comment.
The string should be saved inside constant variables
| const el = e.target; | ||
| if (el.tagName !== "BUTTON") return; | ||
| const text = el.innerText; | ||
| if (text === "C") { |
Member
There was a problem hiding this comment.
Same for this and all occurences
| calculate(); | ||
| return; | ||
| } | ||
| if (el.className === "") { |
Member
There was a problem hiding this comment.
Add else if and not just if to prevent check every if statement
|
|
||
| function appendDigit(el) { | ||
| const val = Number(el.innerText); | ||
| if (Number.isNaN(val)) return; |
| const val = Number(el.innerText); | ||
| if (Number.isNaN(val)) return; | ||
| if (bool) { | ||
| firstNum = firstNum * 10 + val; |
Member
There was a problem hiding this comment.
Save 10 into a variable
Also you can add return statement under this line to avoid writing the if
| res = firstNum - secondNumb; | ||
| break; | ||
| default: | ||
| return; |
Member
There was a problem hiding this comment.
You dont really need empty default, if no case is met the function will simply terminate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.