Add initial calculator functionality with operator buttons and event …#20
Open
reutmaduel114-collab wants to merge 1 commit into
Conversation
Tamir198
requested changes
Dec 8, 2025
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "liveServer.settings.port": 5501 | |||
Member
There was a problem hiding this comment.
You dont have to push this file
| numbers.forEach(btn => { | ||
| btn.addEventListener('click', () => { | ||
| const value = btn.textContent; | ||
| console.log(currentOperator) |
| const value = btn.textContent; | ||
| console.log(currentOperator) | ||
| if (currentOperator == null) { | ||
| FirstNumber = (FirstNumber ?? "") + value; |
Member
There was a problem hiding this comment.
variables should not start with capital letter
| console.log(`FirstNumber ${FirstNumber}`); | ||
| display.textContent = FirstNumber; | ||
| } | ||
| else { |
Member
There was a problem hiding this comment.
If you will add a return above you will have no need for this else block
| }); | ||
|
|
||
|
|
||
| plus.addEventListener('click', function () { |
Member
There was a problem hiding this comment.
Instead of repeating the event listener addition, can you create a single function like you did on top?
|
|
||
| if (['+', '-', '*', '/'].includes(lastChar)) { | ||
| display.textContent = text.slice(0, -1) + currentOperator; //replace last operator with new one | ||
| } else { |
| SecondNumber = null; | ||
| currentOperator = null; | ||
| result = null; | ||
| display.innerHTML = ' '; // Keep display from collapsing |
Member
There was a problem hiding this comment.
Never use innerHTML its very dangerous method
|
|
||
| equal.addEventListener('click', function () { | ||
| if (currentOperator == '+') { | ||
| result = Number(FirstNumber) + Number(SecondNumber); |
| result = Number(FirstNumber) + Number(SecondNumber); | ||
| } | ||
|
|
||
| if (currentOperator == '-') { |
Member
There was a problem hiding this comment.
Use else if to avoid check all of the ifs
| if (currentOperator == '/') { | ||
| result = Number(FirstNumber) / Number(SecondNumber); | ||
| } | ||
| const limitedResult = Number(result.toFixed(8)); // Limit to 8 decimal places |
Member
There was a problem hiding this comment.
8 should be a constant variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…handling