feat: calculator excercise tamar m.#21
Open
tamarmatza-commits wants to merge 1 commit into
Open
Conversation
Write the js for the calc.
Tamir198
requested changes
Dec 8, 2025
Tamir198
left a comment
Tamir198
left a comment
Member
There was a problem hiding this comment.
Hey left you some comments, good work overall
| let result; | ||
|
|
||
| const display = document.querySelector('.display'); | ||
| const numbers = document.querySelectorAll('.number'); |
Member
There was a problem hiding this comment.
This is a good practice to get all of the numbers at once
|
|
||
| numbers.forEach((numButton) => { | ||
| numButton.addEventListener('click', () => { | ||
| if (display.textContent === '0') { |
Member
There was a problem hiding this comment.
0 should be saved inside constant variable
| button.addEventListener('click', () => { | ||
| calc(); | ||
|
|
||
| operator = button.textContent; |
Member
There was a problem hiding this comment.
I would add a null check on the operator
| result = result * parseInt(operand); | ||
| break; | ||
| case '/': | ||
| result = result / parseInt(operand); |
Member
There was a problem hiding this comment.
What will you see in case of number/0?
| operand = ''; | ||
| result = 0; | ||
|
|
||
| display.textContent = '0'; |
Member
There was a problem hiding this comment.
If you would removed the above 0 into constant you could reuse it in here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write the js for the calc.