final update - Asher Pe'er#22
Open
AsherPe wants to merge 1 commit into
Open
Conversation
Tamir198
requested changes
Dec 8, 2025
|
|
||
| number.forEach(button => { | ||
| button.addEventListener('click', function () { | ||
| console.log(button.textContent) |
| console.log(button.textContent) | ||
| input = input + button.textContent | ||
| if (operation !== "") | ||
| display.textContent = x + " " + operation + " " + input |
Member
There was a problem hiding this comment.
You could add return statement in here then you will not need the else
|
|
||
|
|
||
|
|
||
| const op = [add, sub, mul, div] |
Member
There was a problem hiding this comment.
Maybe give a more meaningful name? like operators
|
|
||
| y = input | ||
| num1 = Number(x) | ||
| num2 = Number(y) |
Member
There was a problem hiding this comment.
I would add a NAN check in here
| break | ||
| case "/": | ||
| if (num2 == 0) { | ||
| sum = "Cannot divide by zero" // exception |
Member
There was a problem hiding this comment.
I dont think that you need the comment, its not adding any thing.
For me the code is understandable as is
| } | ||
| } | ||
|
|
||
| if (sum=="Cannot divide by zero") { |
Member
There was a problem hiding this comment.
Also extract this into constant variable
| y = "" | ||
| sum = "" | ||
| operation = "" | ||
| display.innerHTML = " " |
Member
There was a problem hiding this comment.
Never use innerHTMl its very dangerous method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.