Lidor-Calculator#26
Open
Lidor-Tal wants to merge 1 commit into
Open
Conversation
Tamir198
requested changes
Dec 8, 2025
| <button class="number" id="number-3">3</button> | ||
| </div> | ||
| <div class="row operations"> | ||
| <button id="add" onclick="getOperator(`+`)">+</button> |
Member
There was a problem hiding this comment.
Dont mix html and js, add your functionality from the js file
| @@ -0,0 +1,85 @@ | |||
| let input1 = "", | |||
| input2 = "", | |||
| result = null; | |||
Member
There was a problem hiding this comment.
result just like this will be undefined is it ok ?
If yes yo u dont need to explicitly give this the value
| let display = document.querySelector(".display"); | ||
|
|
||
| // # Get numbers from the user | ||
| numberButtons.forEach((btn) => { |
Member
There was a problem hiding this comment.
Comment like this are not helpful, the code should explain itself
| // # Get numbers from the user | ||
| numberButtons.forEach((btn) => { | ||
| btn.addEventListener("click", () => { | ||
| console.log("btn", btn); |
| }); | ||
| }); | ||
|
|
||
| // # Receive numbers and save them to the right input |
Member
There was a problem hiding this comment.
Same comment in here about comments in the code,
| function getNumbers(number) { | ||
| if (newNumbers) { | ||
| input1 += number; | ||
| display.textContent = input1; |
Member
There was a problem hiding this comment.
You can have early return in here to avoid using else
|
|
||
| // # Get the Operator and calculate the number | ||
| function getOperator(opr) { | ||
| if (newNumbers) { |
Member
There was a problem hiding this comment.
This entire if else could be a function and just call it
|
|
||
| // # Clear the date for another calculate | ||
| function clearAll(equal) { | ||
| if (equal !== "=") { |
| // # Clear the date for another calculate | ||
| function clearAll(equal) { | ||
| if (equal !== "=") { | ||
| display.innerHTML = " "; |
Member
There was a problem hiding this comment.
Never use innerHTMl its very dangerous
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.