Skip to content

js#3

Open
morielturgeman wants to merge 2 commits into
ColmanDevClubORG:mainfrom
morielturgeman:js-creation
Open

js#3
morielturgeman wants to merge 2 commits into
ColmanDevClubORG:mainfrom
morielturgeman:js-creation

Conversation

@morielturgeman

Copy link
Copy Markdown

No description provided.

@Tamir198 Tamir198 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey left you some comments

Comment thread script.js Outdated
const multiply_op=document.getElementById('multiply');
const equalButton = document.getElementById('equal');

numberButtons.forEach((button)=>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good practice using for loop, did you check all edge cases that this is actually working?

Comment thread script.js Outdated
Comment thread script.js Outdated
Comment thread style.css Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants