fix(reticulum): stop blocking LoRa BLE while healthy RNode is online - #1036
Conversation
Exclusive GATT dispose belongs only to bleBondRemoved / LTK recovery. Holding it for every online BLE RNode blocked MeshCore coexistence after #1034.
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Colorado-Mesh/mesh-client/.coderabbit.yaml Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe runtime no longer disposes or exclusively holds LoRa GATT when a healthy BLE RNode is online. Exclusive disposal remains limited to bond-recovery handling. Documentation and regression assertions reflect this behavior. ChangesRNode bond recovery handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Low 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
releaseGattBleCentral) is only forbleBondRemoved/ LTK desync recovery — not while a healthy BLE RNode is online.Test plan
useReticulumRuntime.reconnect-hardening.test.ts(pre-commit / local)rnode_bond_recoveryerror)Summary by CodeRabbit