Skip to content

test: give two slow tests time to finish under full-suite load - #1281

Closed
RobertMTalbot wants to merge 1 commit into
Colorado-Mesh:mainfrom
RobertMTalbot:test/slow-test-timeouts
Closed

RobertMTalbot wants to merge 1 commit into
Colorado-Mesh:mainfrom
RobertMTalbot:test/slow-test-timeouts

Conversation

@RobertMTalbot

@RobertMTalbot RobertMTalbot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Since #1278, renderer-ui shard 3/3 fails on main and on every PR that runs the full suite (#1280 included). The new unread-watermark cases take 2-5 s each alone, so the 5 s default times them out under a full shard; locale-quality (~5 s alone) times out the same way locally. Both get a 30 s limit; no logic changes.

Summary by CodeRabbit

  • Tests
    • Increased the time allowed for unread-message indicator checks to complete. This affects automated testing only; there are no changes to the app’s behavior or user-facing features.

Since Colorado-Mesh#1278, renderer-ui shard 3/3 fails on main (and so on every PR that
runs the full suite). The new "keeps selected channel unread visible until
read" cases render the whole Chat panel twice and take 2-5 s each on their
own, so the 5 s default times them out under a full shard's load; locally,
`pnpm run check:pr` times out four of the six. locale-quality runs the whole
i18n checker in a child process, about 5 s alone, and times out the same way.

Both get a 30 s limit. No test logic changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EHFPfW7vZXpRdR3tBBTX3r
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Colorado-Mesh/mesh-client/.coderabbit.yaml
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: 5180f824-832c-4f92-8d71-fdd746ef6927
📥 Commits

Reviewing files that changed from the base of the PR and between 9ffbb63 and 3342609.

⛔ Files ignored due to path filters: 1
  • src/renderer/locales/locale-quality.test.ts is excluded by !src/renderer/locales/**
📒 Files selected for processing: 1
  • src/renderer/components/ChatPanel.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The parameterized unread-watermark test now uses a 30-second timeout instead of the test runner’s default timeout.

Changes: Unread-watermark test

Layer / File(s) Summary
Set test timeout
src/renderer/components/ChatPanel.test.tsx
The parameterized unread-watermark test now uses a 30-second timeout.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: rinchen

Merge Risk: ⚪ Minimal · up to 33426

This change gives the affected tests more time under suite load and does not alter shipped behavior. No actionable merge-blocking risk is evident.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately describes the main change: increasing time available for two slow tests under full-suite load.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rinchen rinchen added the chore Internal app functionality updates; non-user-facing changes and repo maintenance label Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Internal app functionality updates; non-user-facing changes and repo maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants