[rinchen]

Summary

• Minified Electron main is ~730.1 KiB (747575 bytes), which exceeded the 729 * 1024 gate in scripts/esbuild-main-build.test.mjs.
• That single assertion failed both Tests on main (Vitest (main)) and E2E release preflight.
• Raise the budget to 731 * 1024 with an updated size comment.

Test plan

• pnpm exec vitest run scripts/esbuild-main-build.test.mjs --project main
• Confirm Tests + E2E release preflight go green after merge (or on this PR)

Summary by CodeRabbit

• Tests
  • Updated the accepted main bundle size threshold to reflect the current estimated bundle size.
  • No user-facing behavior changes are included in this update.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Colorado-Mesh/mesh-client
• Branch: fix/main-bundle-budget
• File: .coderabbit.yaml
• Commit: 44d5479
• Layers: Repository YAML
• Review profile: QUIET
• Plan: Advanced
• Run ID: dcfc95a9-6057-42ec-8d59-b17309da2160

Commits

Reviewing files that changed from the base of the PR and between 8020ab0 and 44d5479.

Files selected for processing: 1

• scripts/esbuild-main-build.test.mjs

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The main-bundle size estimate changed to approximately 730.1 KiB. The test budget increased to 731 KiB.

Changes: Main bundle size budget

Layer / File(s)	Summary
Update bundle size threshold scripts/esbuild-main-build.test.mjs	The comment estimate changed from approximately 727.8 KiB to 730.1 KiB. The test budget increased from 729 KiB to 731 KiB.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

• Colorado-Mesh/mesh-client#1304: This PR also changes the main-bundle size budget in scripts/esbuild-main-build.test.mjs.
• Colorado-Mesh/mesh-client#1313: This PR also changes the main-bundle size budget in scripts/esbuild-main-build.test.mjs.

Suggested reviewers: cj-vana

Merge Risk: Minimal · up to 44d54

The bundle-size budget update is narrowly scoped and presents no identified merge-blocking risk.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: increasing the main bundle size budget for the CI preflight check.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}