-
-
Notifications
You must be signed in to change notification settings - Fork 13
fix(meshtastic): configure replay last_heard guards + WoA CI runner advance-test #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e8fa4cf
ci: advance-test WoA smoke on windows-11-vs2026-arm
rinchen 37d396a
fix(meshtastic): stop NodeDB configure replay from marking all nodes …
rinchen 0e7ce7d
fix(meshtastic): harden configure replay stall watchdog and phase guards
rinchen 467f4a0
fix(meshtastic): reset configure phase on failure and harden progress…
rinchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # GitHub-hosted labels not yet in actionlint's built-in list. | ||
| self-hosted-runner: | ||
| labels: | ||
| - windows-11-vs2026-arm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
src/renderer/lib/meshtastic/meshtasticConfigurePhase.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
|
|
||
| import { | ||
| getMeshtasticConfigurePhase, | ||
| resetMeshtasticConfigurePhaseForTests, | ||
| setMeshtasticConfigurePhase, | ||
| setMeshtasticConfigureProgressHandler, | ||
| touchMeshtasticConfigureProgress, | ||
| } from './meshtasticConfigurePhase'; | ||
|
|
||
| describe('meshtasticConfigurePhase', () => { | ||
| it('keeps progress handler after configure ends so refresh can reset stall timer', () => { | ||
| resetMeshtasticConfigurePhaseForTests(); | ||
| const onProgress = vi.fn(); | ||
| setMeshtasticConfigureProgressHandler(onProgress); | ||
|
|
||
| setMeshtasticConfigurePhase(true); | ||
| touchMeshtasticConfigureProgress(); | ||
| expect(onProgress).toHaveBeenCalledTimes(1); | ||
|
|
||
| setMeshtasticConfigurePhase(false); | ||
| expect(getMeshtasticConfigurePhase()).toBe(false); | ||
|
|
||
| setMeshtasticConfigurePhase(true); | ||
| touchMeshtasticConfigureProgress(); | ||
| expect(onProgress).toHaveBeenCalledTimes(2); | ||
| }); | ||
|
|
||
| it('does not invoke progress handler when configure phase is inactive', () => { | ||
| resetMeshtasticConfigurePhaseForTests(); | ||
| const onProgress = vi.fn(); | ||
| setMeshtasticConfigureProgressHandler(onProgress); | ||
|
|
||
| touchMeshtasticConfigureProgress(); | ||
| expect(onProgress).not.toHaveBeenCalled(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /** Meshtastic device.configure / NodeDB replay phase — shared by nodeStore and wireEffects. */ | ||
|
|
||
| let configuring = false; | ||
| let onConfigureProgress: (() => void) | null = null; | ||
|
|
||
| export function setMeshtasticConfigurePhase(value: boolean): void { | ||
| configuring = value; | ||
| // Progress handler lifetime == wire attach lifetime (cleared on detach / test reset only). | ||
| } | ||
|
|
||
| export function getMeshtasticConfigurePhase(): boolean { | ||
| return configuring; | ||
| } | ||
|
|
||
| /** Register BLE configure stall watchdog reset (wireEffects only). */ | ||
| export function setMeshtasticConfigureProgressHandler(handler: (() => void) | null): void { | ||
| onConfigureProgress = handler; | ||
| } | ||
|
|
||
| /** Reset configure stall timer while NodeDB / FromRadio frames still arrive. */ | ||
| export function touchMeshtasticConfigureProgress(): void { | ||
| if (!configuring) return; | ||
| onConfigureProgress?.(); | ||
| } | ||
|
|
||
| /** Test-only reset. */ | ||
| export function resetMeshtasticConfigurePhaseForTests(): void { | ||
| configuring = false; | ||
| onConfigureProgress = null; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Add regression coverage for the JSON timestamp contract.
This changes exported node data from its stored timestamp representation to Unix seconds and adds
last_heard_unit. Add aNodeListPanel.test.tsxcase that verifies a millisecond-valued node timestamp exports the expected seconds value and'unix_sec'unit.As per coding guidelines, “Testing: Ship a passing test for behavioral changes; do not call the task done without it.”
🤖 Prompt for AI Agents
Source: Coding guidelines