Repository navigation
[main] fix: clear skills badge and show expiry - #208
Merged
Merged
Conversation
The sidebar dot stayed on after the user opened Skills because only an opened live skill was marked seen, and the page defaults to drafts. Opening Skills now clears the update badge. Parent write_skill also publishes the same update event so a direct skill write lights the dot. Signed-off-by: Tom Liu (Liu Hsiu-Chi) <0xtomlord1122@gmail.com>
Unpinned self-improvement skills archive 30 days after last use, then delete 10 days after archive. The skills page now shows that countdown on the list, preview, and archived rows. Signed-off-by: Tom Liu (Liu Hsiu-Chi) <0xtomlord1122@gmail.com>
Signed-off-by: Tom Liu (Liu Hsiu-Chi) <0xtomlord1122@gmail.com>
[dev] fix: clear skills badge and show expiry
Signed-off-by: Tom Liu (Liu Hsiu-Chi) <0xtomlord1122@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The Skills sidebar dot stayed on after the user opened Skills, and the only way to clear it was a full reload. Self-improvement skills also expire on a curator clock, but the skills page never showed how long was left.
feab25bf: Opening Skills, including the Cmd+2 shortcut, now marks skill updates seen so the dot clears without a reload. Parent
write_skillpublishes the same update event, so a direct skill write lights the badge too.f4aad4c1: Unpinned self-improvement skills now expose
expires_at. The page shows when a skill will archive, or when an archived skill will be deleted. Pinned skills do not expire.8c3717db: Generated API types match the new field, and the expiry view matches the formatter.
Reference
dev PR