Repository navigation
[main] feat: surface recently changed skills - #210
Merged
Merged
Conversation
A skill update notification now opens the Skills tab with the changed skills first. Pending drafts still open the Drafts tab. The recent order lasts for the app session and does not clear when the badge does. Signed-off-by: Tom Liu (Liu Hsiu-Chi) <0xtomlord1122@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Skill review writes happen often, and the notification only landed on the skills page. The list stayed alphabetical, so the changed skill was hard to find. Pending drafts still need to win when both kinds of updates exist.
13bafeff: A skill update notification opens the Skills tab and puts the changed skills first, with a recent badge. Pending drafts still open the Drafts tab. The recent order lasts for the app session and stays after the badge is cleared.