fix(release): verify bootstrap python on the path that actually ships - #1505
Open
benceruleanlu wants to merge 1 commit into
Open
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Comment |
The hook fetched and verified app-wrapper/extraResources/bootstrap-python/<platform>, which stopped being the packaged path when #1484 moved Windows to todesktop-targets/ and this branch moved Linux there too. It kept reporting success over a tree nothing copies, leaving the CI check that runs before the upload as the only guard on the shipped payload. Resolve the destination from todesktop.json — the same config packaging reads — so verification cannot drift from packaging again. A staged directory is verified in place; a missing one is fetched into it, restoring the repair path the 0.6.4 post-mortem asked for. Covered by a test that drives the hook over a temp build tree.
benceruleanlu
force-pushed
the
bl/arm64-beforebuild-verifies-shipped-path
branch
from
September 9, 2026 01:33
572debc to
d94aa83
Compare
benceruleanlu
removed this pull request from stack #1510
September 9, 2026 01:34
benceruleanlu
added this pull request to stack #1513
September 9, 2026 01:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a stack of review fixes for #1486. Based on #1504.
Summary
scripts/todesktop-beforeBuild.cjsfetched and verifiedapp-wrapper/extraResources/bootstrap-python/<platform>. That stopped being the packaged path when #1484 moved Windows totodesktop-targets/, and #1486 moved Linux there too. The hook kept reporting success over a tree nothing copies.It was added after the 0.6.4 post-mortem, where a release shipped with no bootstrap Python. Because CI pre-uploads the directory, the fetch script verifies the uploaded copy rather than re-downloading, which made the hook a genuine post-upload integrity check. Pointed at a dead path it checks nothing, leaving the CI step that runs before the upload as the only guard on the shipped payload.
Feature behavior
The hook now resolves the destination from
todesktop.json, using ToDesktop's own precedence: per-target, then per-platform, then the base list. Verification therefore cannot drift from packaging again.A directory already staged by CI is verified in place, with no network access. A missing one is fetched into it, which restores the repair path. Architectures with no bootstrap Python, such as Linux ARM64, still skip. A target that declares no bootstrap resource now fails the build instead of being silently skipped.
Test coverage and validation
todesktop.jsondeclares, fails when the tree arrived without its Python or without uv, and skips Linux ARM64.Change breakdown
Total changed lines: 211 (188 added, 23 deleted).
Product code
Test code
Documentation
Configuration and CI
Generated files
Lockfiles
Vendored code