Support Customer.io messages inside local ComfyUI on Desktop - #1527
Draft
benceruleanlu wants to merge 6 commits into
Draft
benceruleanlu wants to merge 6 commits into
benceruleanlu wants to merge 6 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
benceruleanlu
added this pull request to stack #1529
September 16, 2026 03:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Customer.io messages can now appear inside the local ComfyUI page in Desktop. The main process enables the browser SDK only for a focused, visible local ComfyUI panel with telemetry consent and a confirmed Firebase identity. Signing out, changing accounts, hiding the panel, or revoking consent clears the messaging session and removes visible messages.
The integration uses the existing Cloud Customer.io source and Firebase UID, with
desktop/local-workflowas the campaign page target. The SDK runs without Node access and uses its own in-memory browser storage. Native message links open externally while preserving the workflow. Launcher, onboarding, remote installs, and embedded Cloud are excluded from this Desktop integration.The fixture returns stable delivery IDs across queue polls and waits through a second poll before dismissing. Lifecycle-view tests unmount their wrappers so the existing placeholder timer cannot outlive happy-dom's environment.
Validation
Before release, validate a restricted live Customer.io campaign and packaged macOS/Windows behavior. Audit campaigns without page restrictions because those may also match Desktop. Runtime overrides and campaign targeting are documented in
docs/customerio-messaging.md.Change breakdown
Changed lines = additions + deletions. No merge-only changes.
Documentation paths
docs/customerio-messaging.mdTest code paths
e2e/customerio.test.tssrc/main/lib/customerIoMessaging.test.tssrc/main/lib/firebaseAuthIdentity.test.tssrc/preload/comfyPreload.test.tssrc/renderer/src/customerIo/controller.test.tssrc/renderer/src/panel/ComfyLifecycleView.test.tsBuild/configuration paths
electron.vite.config.tspackage.jsonscripts/customerio-script.tstsconfig.node.jsonvitest.config.tsLockfiles paths
pnpm-lock.yamlProduct code paths
src/main/host/attach.tssrc/main/host/createHostWindow.tssrc/main/host/registry.tssrc/main/lib/customerIoEvents.tssrc/main/lib/customerIoMessaging.tssrc/main/lib/firebaseAuthIdentity.tssrc/main/lib/ipc/registerSettingsHandlers.tssrc/preload/comfyPreload.tssrc/preload/customerIoPreload.tssrc/preload/customerIoScript.d.tssrc/renderer/src/customerIo/controller.tssrc/renderer/src/customerIo/index.tssrc/shared/customerIo.tsNo generated or vendored files changed.