Define Customer.io page targets for Desktop surfaces - #1528
Draft
benceruleanlu wants to merge 1 commit into
Draft
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
benceruleanlu
added this pull request to stack #1529
September 16, 2026 03:05
benceruleanlu
force-pushed
the
bl/desktop-messaging-targets
branch
from
September 16, 2026 03:47
b3954df to
915b566
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Rename the in-ComfyUI Customer.io page to
desktop/comfyuiand make the page an explicit main-process session field. Reservedesktop/launcherin the shared contract so the two surfaces can be targeted independently by Customer.io page rules. This layer defines the contract; launcher activation is a subsequent stack change.The SDK reports the supplied synthetic page and drops stale page events for a different surface. Local paths, query strings, and referrers remain excluded from page properties.
Validation
12 focused eligibility/controller tests passed. The built-preload Electron fixture passed with the real SDK, including page matching, message display/dismissal, held-request consent revocation, account switching, and URL-field privacy. Required pre-commit typechecks, lint, and formatting passed.
No live campaign or packaged release validation was performed for this layer.
Change breakdown
Changed lines = additions + deletions. No merge-only changes.
Documentation paths
docs/customerio-messaging.mdTest code paths
e2e/customerio.test.tssrc/renderer/src/customerIo/controller.test.tsProduct code paths
src/main/lib/customerIoMessaging.tssrc/renderer/src/customerIo/controller.tssrc/renderer/src/customerIo/index.tssrc/shared/customerIo.tsNo generated or vendored files changed.