Skip to content

Define Customer.io page targets for Desktop surfaces - #1528

Draft
benceruleanlu wants to merge 1 commit into
bl/desktop-customerio-in-appfrom
bl/desktop-messaging-targets
Draft

benceruleanlu wants to merge 1 commit into
bl/desktop-customerio-in-appfrom
bl/desktop-messaging-targets

Conversation

@benceruleanlu

Copy link
Copy Markdown
Member

Behavior

Rename the in-ComfyUI Customer.io page to desktop/comfyui and make the page an explicit main-process session field. Reserve desktop/launcher in the shared contract so the two surfaces can be targeted independently by Customer.io page rules. This layer defines the contract; launcher activation is a subsequent stack change.

The SDK reports the supplied synthetic page and drops stale page events for a different surface. Local paths, query strings, and referrers remain excluded from page properties.

Validation

12 focused eligibility/controller tests passed. The built-preload Electron fixture passed with the real SDK, including page matching, message display/dismissal, held-request consent revocation, account switching, and URL-field privacy. Required pre-commit typechecks, lint, and formatting passed.

No live campaign or packaged release validation was performed for this layer.

Change breakdown

Changed lines = additions + deletions. No merge-only changes.

Category Files Added Deleted Share of changed lines
Documentation 1 1 1 4.7%
Test code 2 8 4 27.9%
Product code 4 19 10 67.4%
Total 7 28 15 100%

Documentation paths

  • docs/customerio-messaging.md

Test code paths

  • e2e/customerio.test.ts
  • src/renderer/src/customerIo/controller.test.ts

Product code paths

  • src/main/lib/customerIoMessaging.ts
  • src/renderer/src/customerIo/controller.ts
  • src/renderer/src/customerIo/index.ts
  • src/shared/customerIo.ts

No generated or vendored files changed.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@benceruleanlu
benceruleanlu added this pull request to stack #1529 September 16, 2026 03:05
@benceruleanlu
benceruleanlu force-pushed the bl/desktop-messaging-targets branch from b3954df to 915b566 Compare September 16, 2026 03:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant