Resolve Desktop person identity through authenticated Cloud API - #1530
Draft
benceruleanlu wants to merge 1 commit into
Draft
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
benceruleanlu
added this pull request to stack #1529
September 16, 2026 03:07
benceruleanlu
force-pushed
the
bl/desktop-cloud-person-identity
branch
from
September 16, 2026 03:47
0e1fbdf to
2eb004f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Add a main-process Cloud identity client for
GET /api/user. Keep the canonical account ID separate from the optionalfirebase_uidused by existing Customer.io profiles. Legacy responses without that field remain usable account responses; callers must not substitute the canonical ID for a Firebase UID.CloudSessionshares concurrent identity lookups and announces credential changes immediately. Logout, login completion, active-token refresh, and workspace switches cancel obsolete lookups; a late response cannot supply the previous account's identity. Tokens remain in the main process. This library layer is consumed by launcher messaging later in the stack.The optional field requires Cloud #9467 and #9468 before launcher messaging can identify newly authorized sessions. Existing grants need fresh authorization to acquire proven Firebase provenance.
Validation
28 focused Cloud identity/session tests passed. Coverage includes linked identities, absent legacy metadata, rejected/malformed responses, cancellation, shared requests, logout and workspace-switch races. Required pre-commit typechecks, lint, and formatting passed. No live authenticated request or deployment was performed.
Change breakdown
Changed lines = additions + deletions. No merge-only changes.
Test code paths
src/main/cloud/identity.test.tssrc/main/cloud/session.test.tsProduct code paths
src/main/cloud/identity.tssrc/main/cloud/session.tsNo generated or vendored files changed.