Isolate Customer.io SDK from local URL identity and metadata - #1531
Draft
benceruleanlu wants to merge 1 commit into
Draft
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
benceruleanlu
added this pull request to stack #1529
September 16, 2026 03:17
benceruleanlu
force-pushed
the
bl/desktop-messaging-environment
branch
from
September 16, 2026 03:47
8755065 to
dfcde55
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Give the bundled Customer.io SDK a private URL and storage environment from its first instruction. The SDK otherwise processes
ajs_uidbefore source middleware and adds UTM/ad-referrer data after that middleware, allowing a local URL to select an unverified messaging identity or disclose workflow metadata.SDK URL reads now return a synthetic Desktop URL with an empty query/referrer. Its fallback page-rule matching uses the synthetic surface path. SDK location writes cannot replace ComfyUI; message actions use the existing main-process bridge. Browser persistence is disabled. The host page's actual URL, storage, and browser globals are unchanged.
Validation
The built-preload Electron test passed with the real SDK and intercepted network traffic. The fixture includes
ajs_uid,ajs_event, UTM/ad identifiers, a private referrer, and a higher-priority message targeting the real local pathname. Only verified users reach the in-app queue, the private route does not render, and outgoing events contain none of those values. Rendering, dismissal, held-request revocation and existing workflow storage checks also passed.Required pre-commit typechecks, lint, and formatting passed. Live campaign and packaged release validation remain outstanding.
Change breakdown
Changed lines = additions + deletions. No merge-only changes.
Documentation paths
docs/customerio-messaging.mdTest code paths
e2e/customerio.test.tsBuild/configuration paths
scripts/customerio-script.tsProduct code paths
src/renderer/src/customerIo/environment.tssrc/renderer/src/customerIo/index.tsNo generated or vendored files changed.