Skip to content

Isolate Customer.io SDK from local URL identity and metadata - #1531

Draft
benceruleanlu wants to merge 1 commit into
bl/desktop-cloud-person-identityfrom
bl/desktop-messaging-environment
Draft

benceruleanlu wants to merge 1 commit into
bl/desktop-cloud-person-identityfrom
bl/desktop-messaging-environment

Conversation

@benceruleanlu

Copy link
Copy Markdown
Member

Behavior

Give the bundled Customer.io SDK a private URL and storage environment from its first instruction. The SDK otherwise processes ajs_uid before source middleware and adds UTM/ad-referrer data after that middleware, allowing a local URL to select an unverified messaging identity or disclose workflow metadata.

SDK URL reads now return a synthetic Desktop URL with an empty query/referrer. Its fallback page-rule matching uses the synthetic surface path. SDK location writes cannot replace ComfyUI; message actions use the existing main-process bridge. Browser persistence is disabled. The host page's actual URL, storage, and browser globals are unchanged.

Validation

The built-preload Electron test passed with the real SDK and intercepted network traffic. The fixture includes ajs_uid, ajs_event, UTM/ad identifiers, a private referrer, and a higher-priority message targeting the real local pathname. Only verified users reach the in-app queue, the private route does not render, and outgoing events contain none of those values. Rendering, dismissal, held-request revocation and existing workflow storage checks also passed.

Required pre-commit typechecks, lint, and formatting passed. Live campaign and packaged release validation remain outstanding.

Change breakdown

Changed lines = additions + deletions. No merge-only changes.

Category Files Added Deleted Share of changed lines
Documentation 1 8 3 8.5%
Test code 1 24 4 21.5%
Build/configuration 1 15 9 18.5%
Product code 2 67 0 51.5%
Total 5 114 16 100%

Documentation paths

  • docs/customerio-messaging.md

Test code paths

  • e2e/customerio.test.ts

Build/configuration paths

  • scripts/customerio-script.ts

Product code paths

  • src/renderer/src/customerIo/environment.ts
  • src/renderer/src/customerIo/index.ts

No generated or vendored files changed.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@benceruleanlu
benceruleanlu added this pull request to stack #1529 September 16, 2026 03:17
@benceruleanlu
benceruleanlu force-pushed the bl/desktop-messaging-environment branch from 8755065 to dfcde55 Compare September 16, 2026 03:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant