Coordinate Customer.io messaging across Desktop window surfaces - #1532
Draft
benceruleanlu wants to merge 1 commit into
Draft
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
benceruleanlu
added this pull request to stack #1529
September 16, 2026 03:25
benceruleanlu
force-pushed
the
bl/desktop-messaging-surfaces
branch
from
September 16, 2026 03:47
e002d57 to
4f20255
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Move Customer.io ownership from an installation attachment to the host window. The coordinator grants messaging to the visible local ComfyUI document or the launcher panel, revoking the previous surface first. It follows lazy panel creation/destruction and ComfyUI view replacement, validates the exact launcher document URL, and retires listeners at window close.
Launcher identity comes from the authenticated Cloud API's optional Firebase provenance field; canonical IDs are never substituted. Consent, onboarding/progress takeovers, visibility, credential changes, navigation, and stale asynchronous lookups gate delivery. The first-use mode broadcast now reaches the matching host even when it is not the first window in the registry. Embedded Cloud retains its existing messaging integration.
This layer supplies the main-process policy; the next layer connects the launcher preload and CSP.
Validation
14 messaging tests passed, covering document handshakes, legacy grants, stale lookup rejection, credential changes, consent, handoff ordering, view replacement and external navigation. Another 103 focused host/auth tests passed (attachment, panel lifecycle, close helpers, detach and Firebase consensus). Required pre-commit typechecks, lint and formatting passed. Renderer and packaged/live campaign verification follow in later layers.
Change breakdown
Changed lines = additions + deletions. No merge-only changes.
Product code paths
src/main/host/attach.tssrc/main/host/createHostWindow.tssrc/main/host/panelView.tssrc/main/index.tssrc/main/lib/customerIoDocument.tssrc/main/lib/customerIoMessaging.tssrc/main/lib/ipc/registerSettingsHandlers.tsTest code paths
src/main/lib/customerIoMessaging.test.tsNo generated or vendored files changed.