Render Customer.io messages in the Desktop launcher - #1533
Draft
benceruleanlu wants to merge 2 commits into
Draft
benceruleanlu wants to merge 2 commits into
benceruleanlu wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
benceruleanlu
added this pull request to stack #1529
September 16, 2026 03:31
benceruleanlu
force-pushed
the
bl/desktop-launcher-messaging
branch
from
September 16, 2026 03:47
8d4d34b to
e524fef
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Connect the launcher preload to the window coordinator and allow the pinned Customer.io/Gist network and frame hosts in the panel CSP. Eligible signed-in users can receive messages targeted to
desktop/launcher, while local ComfyUI usesdesktop/comfyui. An online event repeats the main-process handshake so an unavailable identity/SDK can retry. No inline-script or general CSP relaxation is added.Launcher identity requires Cloud #9467 and #9468; old OAuth grants require fresh sign-in to acquire proven Firebase provenance. Documentation covers page targeting, eligibility, identity dependencies, and release verification.
Validation
Both real-SDK Electron fixtures passed: local ComfyUI and the launcher under its production CSP at a file URL. They cover display, opened metrics, dismissal, account changes, held-request revocation, private URL/query/referrer isolation, preserved host storage and continued interaction.
The CSP unit test retains an exact three-origin frame allowlist covering Typeform and the two message hosts; its updated expectation passed with all 19 CSP tests.
Required pre-commit typechecks, lint, and formatting passed. Native multi-view handoff, remaining CI gates, and packaged/live campaign verification are tracked separately.
Change breakdown
Changed lines = additions + deletions. No merge-only changes.
Documentation paths
docs/customerio-messaging.mdTest code paths
e2e/customerio.test.tssrc/renderer/csp.test.tsProduct code paths
src/preload/customerIoPreload.tssrc/preload/index.tssrc/renderer/panel.htmlNo generated or vendored files changed.