Skip to content

Render Customer.io messages in the Desktop launcher - #1533

Draft
benceruleanlu wants to merge 2 commits into
bl/desktop-messaging-surfacesfrom
bl/desktop-launcher-messaging
Draft

benceruleanlu wants to merge 2 commits into
bl/desktop-messaging-surfacesfrom
bl/desktop-launcher-messaging

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Sep 16, 2026

Copy link
Copy Markdown
Member

Behavior

Connect the launcher preload to the window coordinator and allow the pinned Customer.io/Gist network and frame hosts in the panel CSP. Eligible signed-in users can receive messages targeted to desktop/launcher, while local ComfyUI uses desktop/comfyui. An online event repeats the main-process handshake so an unavailable identity/SDK can retry. No inline-script or general CSP relaxation is added.

Launcher identity requires Cloud #9467 and #9468; old OAuth grants require fresh sign-in to acquire proven Firebase provenance. Documentation covers page targeting, eligibility, identity dependencies, and release verification.

Validation

Both real-SDK Electron fixtures passed: local ComfyUI and the launcher under its production CSP at a file URL. They cover display, opened metrics, dismissal, account changes, held-request revocation, private URL/query/referrer isolation, preserved host storage and continued interaction.

The CSP unit test retains an exact three-origin frame allowlist covering Typeform and the two message hosts; its updated expectation passed with all 19 CSP tests.

Required pre-commit typechecks, lint, and formatting passed. Native multi-view handoff, remaining CI gates, and packaged/live campaign verification are tracked separately.

Change breakdown

Changed lines = additions + deletions. No merge-only changes.

Category Files Added Deleted Share of changed lines
Documentation 1 48 18 44.3%
Test code 2 56 20 51.0%
Product code 3 5 2 4.7%
Total 6 109 40 100%

Documentation paths

  • docs/customerio-messaging.md

Test code paths

  • e2e/customerio.test.ts
  • src/renderer/csp.test.ts

Product code paths

  • src/preload/customerIoPreload.ts
  • src/preload/index.ts
  • src/renderer/panel.html

No generated or vendored files changed.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@benceruleanlu
benceruleanlu added this pull request to stack #1529 September 16, 2026 03:31
@benceruleanlu
benceruleanlu force-pushed the bl/desktop-launcher-messaging branch from 8d4d34b to e524fef Compare September 16, 2026 03:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant