Keep Customer.io SDK lifecycle serialized through timeouts - #1534
Draft
benceruleanlu wants to merge 1 commit into
Draft
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
benceruleanlu
added this pull request to stack #1529
September 16, 2026 03:37
benceruleanlu
force-pushed
the
bl/desktop-messaging-sdk-lifecycle
branch
from
September 16, 2026 03:47
8ba0574 to
43b6ba5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Keep one owner of Customer.io SDK operations when a network call exceeds the UI's wait limit. Expired operations revoke display immediately and retain ownership until they settle; a later account cannot overtake an unfinished identify/reset. A late successful operation reconciles the latest eligible session from a reset.
Fetch source settings before SDK construction so a network failure can retry safely. After construction, retain the single initialization promise, await actual SDK readiness, and quarantine a partial initialization failure until document reload. In-app identity and route hooks check current eligibility, and route changes now participate in the serialized lifecycle.
Validation
16 focused controller/adapter tests passed, including delayed loading, identify/reset timeouts, stale sessions, offline retry, and overlapping dismissals. The regressions fail on the previous controller. Both real-SDK Electron fixtures passed for local ComfyUI and launcher under production CSP, including display, dismissal, account changes, and immediate input restoration on revocation. Required pre-commit typechecks, lint, and formatting passed.
Change breakdown
Changed lines = additions + deletions. No merge-only changes.
Test code paths
src/renderer/src/customerIo/adapter.test.tssrc/renderer/src/customerIo/controller.test.tsProduct code paths
src/renderer/src/customerIo/adapter.tssrc/renderer/src/customerIo/controller.tssrc/renderer/src/customerIo/index.tsNo generated or vendored files changed.