Conversation
Points the title-bar news bell at the Comfy Router launch, reusing AnnouncementModal by swapping the id, copy, URLs and i18n namespace (the pattern its header comment and the Cloud nodes swap in #1480 established). Copy is Steven's finalized in-app version. A new comfyRouterAnnouncementSeen flag re-lights the bell for everyone who dismissed the Cloud nodes announcement; the old key stays defined. Single CTA (dropped the docs button and beta line). Hero points at media.comfy.org/website/router/, which is not uploaded yet, so it 404s to the gradient fallback until the asset lands. zh strings are machine-written, pending native review.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Points the Desktop launch-announcement modal (the title-bar news bell) at the Comfy Router launch, the same way #1480 did for Comfy Cloud nodes. Reuses
AnnouncementModal.vueby swapping the id, copy, URLs and i18n namespace, which is exactly what its header comment asks for rather than adding a second component.Copy is Steven's finalized in-app version (the Comfy Router Launch Emails / In-App doc): a subhead plus three benefit bullets, restructured onto the modal's checklist layout instead of one dense paragraph.
ANNOUNCEMENT_IDcomfy_cloud_nodes→comfy_routercomfy.org/platform/routermedia.comfy.org/website/router/hero_v1.{mp4,webp}comfy_cloud_nodes→comfy_routerannouncement.cloudNodes.*→announcement.comfyRouter.*cloudNodesAnnouncementSeen→ newcomfyRouterAnnouncementSeenReview focus
media.comfy.org/website/router/hero_v1.{mp4,webp}404s today, so the modal falls back to the.announce-mediagradient. The asset is being uploaded separately; do not merge/ship until it is live. Pointing at the final path now means that is a pure upload, no follow-up code change.comfyRouterAnnouncementSeenis a new key so anyone who dismissed the Cloud nodes announcement still gets this one. The oldcloudNodesAnnouncementSeen(andminimaxAnnouncementSeen) stay defined in the schema, since they are already persisted on users' machines.betafine-print line the Cloud nodes modal carried are gone. The Cloud nodes copy block is left untouched in both locales, so reverting is a one-line namespace change.zh.jsonkeeps its\uXXXXescapes so the diff does not re-serialise the file.Testing
pnpm run typecheckclean across all four projects (node, web, e2e, integration);eslintandprettier --checkclean (also enforced by the pre-commit hook).pnpm devbuilds main/preload/renderer and launches; the modal was reviewed in the running app via the title-bar bell (title, subhead, three checkmark bullets, single CTA, sound toggle).announcement.comfyRouter.*key the template references resolves in bothenandzh(7/7 keys, 3/3 highlights).