Skip to content

feat(announcement): swap the launch modal to Comfy Router - #1560

Draft
deepme987 wants to merge 1 commit into
mainfrom
deepme987/desktop/comfy-router-announcement
Draft

deepme987 wants to merge 1 commit into
mainfrom
deepme987/desktop/comfy-router-announcement

Conversation

@deepme987

Copy link
Copy Markdown
Contributor

What

Points the Desktop launch-announcement modal (the title-bar news bell) at the Comfy Router launch, the same way #1480 did for Comfy Cloud nodes. Reuses AnnouncementModal.vue by swapping the id, copy, URLs and i18n namespace, which is exactly what its header comment asks for rather than adding a second component.

Copy is Steven's finalized in-app version (the Comfy Router Launch Emails / In-App doc): a subhead plus three benefit bullets, restructured onto the modal's checklist layout instead of one dense paragraph.

changed to
ANNOUNCEMENT_ID comfy_cloud_nodescomfy_router
CTA two buttons (Read More + docs) → single Learn About Comfy Routercomfy.org/platform/router
hero media Cloud nodes film → media.comfy.org/website/router/hero_v1.{mp4,webp}
UTM campaign comfy_cloud_nodescomfy_router
i18n namespace announcement.cloudNodes.*announcement.comfyRouter.*
seen-flag cloudNodesAnnouncementSeennew comfyRouterAnnouncementSeen

Review focus

  • Hero asset is not uploaded yet. media.comfy.org/website/router/hero_v1.{mp4,webp} 404s today, so the modal falls back to the .announce-media gradient. The asset is being uploaded separately; do not merge/ship until it is live. Pointing at the final path now means that is a pure upload, no follow-up code change.
  • New seen-flag re-lights the bell. comfyRouterAnnouncementSeen is a new key so anyone who dismissed the Cloud nodes announcement still gets this one. The old cloudNodesAnnouncementSeen (and minimaxAnnouncementSeen) stay defined in the schema, since they are already persisted on users' machines.
  • Single CTA, no beta note. Router copy is one button, so the docs ghost button and the beta fine-print line the Cloud nodes modal carried are gone. The Cloud nodes copy block is left untouched in both locales, so reverting is a one-line namespace change.
  • zh strings are machine-written, no native review yet, consistent with how the MiniMax and Cloud nodes strings landed. Both locale edits are additions-only; zh.json keeps its \uXXXX escapes so the diff does not re-serialise the file.

Testing

  • pnpm run typecheck clean across all four projects (node, web, e2e, integration); eslint and prettier --check clean (also enforced by the pre-commit hook).
  • pnpm dev builds main/preload/renderer and launches; the modal was reviewed in the running app via the title-bar bell (title, subhead, three checkmark bullets, single CTA, sound toggle).
  • Verified every announcement.comfyRouter.* key the template references resolves in both en and zh (7/7 keys, 3/3 highlights).

Points the title-bar news bell at the Comfy Router launch, reusing AnnouncementModal by swapping the id, copy, URLs and i18n namespace (the pattern its header comment and the Cloud nodes swap in #1480 established). Copy is Steven's finalized in-app version.

A new comfyRouterAnnouncementSeen flag re-lights the bell for everyone who dismissed the Cloud nodes announcement; the old key stays defined. Single CTA (dropped the docs button and beta line). Hero points at media.comfy.org/website/router/, which is not uploaded yet, so it 404s to the gradient fallback until the asset lands. zh strings are machine-written, pending native review.
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants