Skip to content

feat(claude-code): add the remaining directory listing fields to plugin.json - #52

Merged
mattmillerai merged 3 commits into
mainfrom
docs/plugin-readme-license
Nov 11, 2026
Merged

mattmillerai merged 3 commits into
mainfrom
docs/plugin-readme-license

Conversation

@mattmillerai

@mattmillerai mattmillerai commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

ELI5

A product listing has a few blanks for the fine print: terms, a support contact, where the source lives, and search keywords. The Claude plugin directory reads those from the plugin's manifest, and ours left four of them empty. This fills them in.

Motivation

The comfy-cloud plugin is being prepared for Anthropic's Claude plugin directory. The directory builds its listing from plugin.json, and a validation run in the developer portal showed terms of service, support, repository, and keywords as not set. #46 — feat(comfy-cloud): add Agent Skills for the Claude directory (BE-25899) already added the README, LICENSE, icon, and the documentation and privacy fields, so only these four remain.

Provenance

  • Authored by: interactive session
  • Verified:
    • Plugin manifest validation: passed on the branch head
    • Terms URL and privacy URL both return 200 (/privacy redirects to /privacy-policy/)
    • Diff against main: plugin.json only
    • Not run: the directory portal's own Validate step against this branch

Reviewer context

Summary

Test plan

  • Re-run Validate in the directory portal and confirm the Listing details step shows terms, support, repository, and keywords
  • /plugin install comfy-cloud@comfy-skills still installs and /mcp still signs in

mattmillerai and others added 2 commits November 10, 2026 20:56
The Anthropic directory validates the plugin folder itself, not the repo
root, and blocks submission without a README of at least 40 words and a
LICENSE inside it. Add both to claude-code/: the README describes the
plugin, its commands, and what it connects to and sends; the LICENSE is
the repo's existing MIT license.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The directory portal warned about a missing icon and privacy policy URL
and showed support, repository, terms and keywords as unset. Set them in
plugin.json, add a 1024px PNG icon at .claude-plugin/icon.png rendered
from the Comfy app icon, and bump the version to 0.1.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 36 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 83 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 90a8b667-a245-4013-9c18-5371ac7a433b
Commits

Reviewing files that changed from the base of the PR and between 8c3bb20 and 55addd2.

Files selected for processing: 1

  • claude-code/.claude-plugin/plugin.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@mattmillerai mattmillerai added the cursor-review Request the Cursor multi-model review matrix label Nov 11, 2026
@vqt123

vqt123 commented Nov 11, 2026

Copy link
Copy Markdown

Starting review at 2f54d27.

@vqt123

vqt123 commented Nov 11, 2026 •

Copy link
Copy Markdown

Approving at 2f54d27.

Should fix

  • Words: People assessing local execution are misled by "runs no local code, scripts, or hooks" in claude-code/README.md:41. Evidence (read, not run): commands/generate-image.md:33 directs Claude to execute curl and open the downloaded file; commands/clone-voice.md:36 directs local ffmpeg processing. These commands also exist at the merge base, which made no such assurance. Say there are no bundled executables or automatic hooks, and disclose command-directed shell actions.
  • Contract: Users expecting to retrieve every output later from their account are misled by claude-code/README.md:42. Evidence (read, not run): an Ideogram request with a negative prompt declines library storage in comfy-cloud-mcp-server/src/partner/client/registry/image.ts:1995; src/tools-execution.ts:6667 takes direct dispatch, whose response explicitly says it was not saved to the asset library at line 4388. The merge base made no storage guarantee. Qualify this sentence and explain that some partner outputs require downloading.

Clean: Correctness, Resilience, Access, Vendor, Rollout, Rules, Cause.
Not covered: Contract/Vendor acceptance: claude plugin validate ./claude-code, then the directory portal's Validate and Listing details steps against this branch; Access/Rollout installation and OAuth: /plugin install comfy-cloud@comfy-skills, then /mcp.
Checked: README claims against existing commands and server source; marketplace source and sibling manifest; license against the root MIT license. Source and referenced tests were read, not run.

~632k effective tokens for this review (3.1M raw; cache reads weighted 0.1x, cache writes 1.25-2x)

vqt123
vqt123 previously approved these changes Nov 11, 2026
#46 already added the plugin README, LICENSE, icon and the license,
documentation and privacy fields. Keep main's versions and drop this
branch's duplicates, leaving only the listing fields main still lacks:
termsOfServiceUrl, supportUrl, repository and keywords (version 0.2.1).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmillerai mattmillerai changed the title feat(claude-code): prepare the comfy-cloud plugin for the Claude directory listing feat(claude-code): add the remaining directory listing fields to plugin.json Nov 11, 2026

@deepme987 deepme987 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vqt123

vqt123 commented Nov 11, 2026 •

Copy link
Copy Markdown

Reviewed at 55addd2 (since 2f54d27): kept main's listing files, added four metadata fields, and bumped the version.

Fixed: Both earlier README findings. The replacement README removes the no-local-execution assurance and describes short-lived output links instead of promising account storage.
Still open: none.

Clean: Correctness, Resilience, Access.
Not covered: Contract/Vendor manifest acceptance: claude plugin validate ./claude-code, then the directory portal's Validate and Listing details steps; Access/Rollout installation and OAuth: /plugin install comfy-cloud@comfy-skills, then /mcp.
Checked: Read the manifest against the merge base, marketplace registration, sibling plugin, and replacement README. Read, not run.

~171k effective tokens for this review (660k raw; cache reads weighted 0.1x, cache writes 1.25-2x)

@mattmillerai
mattmillerai merged commit 05b2488 into main Nov 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Request the Cursor multi-model review matrix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants