Repository navigation
fix(generate-video): offer the same-provider successor first for retired video models - #55
Open
mattmillerai wants to merge 1 commit into
Open
mattmillerai wants to merge 1 commit into
mattmillerai wants to merge 1 commit into
Conversation
…red video models The Retired paragraph sent a prompt-only Sora, Runway gen3a_turbo or Gemini Omni Flash preview request straight to another provider's model without saying so, contradicting Step 0's "ask before a cross-provider re-call" rule, and skipped Gemini's own Omni Flash 1.1 text-to-video successor. Split it: a same-provider successor (Runway Gen-4 Turbo for media, Gemini Omni Flash 1.1 t2v/i2v) runs without re-asking about the swap; anything else (Sora, prompt-only Runway) lists the live cross-provider options, says the named model is retired, and asks which one, unless the user already said any live model will do. Both copies stay byte-identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 41 minutes for your next included review. View limit details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
When someone asks for a video model that has been shut down, the assistant now first offers that same company's newer model and runs it straight away. If the company has no newer model, the assistant explains the original is gone and asks which other company's model to use, so it no longer swaps in a different product (and spends credits on it) without asking.
What
Rewrites the Retired — redirect, don't route. paragraph in
claude-code/commands/generate-video.mdand its legacy mirrorskills/comfy-generate-video.md. The two lines are still byte-identical. The paragraph now says, in this order:gen3a_turbo,gemini-omni-flash-preview), their dates, and "Don't look up the retired name itself — discover its replacement instead."gen3a_turbomaps to the Runway Gen-4 Turboapi_*template, which is image-to-video, so a prompt-only Runway request has no same-provider successor and goes to step 3.gemini-omni-flash-previewmaps to the Gemini Omni Flash 1.1api_*template:_t2vfor a prompt,_i2vfor input media. The agent finds the template withsearch_templateson the successor family name, narrowed by the task tag (never"video"), runs it withrun_template, carries the user's prompt and media into the slotsget_template_schemanames, and says which model ran. The run's own spend prompt still applies.partner_generatevideo slugs, or for input media the like-for-likeapi_*template. It says plainly that the named model is retired and that the options are other providers' products, then asks which one before callingpartner_generateorrun_template. The agent does not quote a price for apartner_generatepick (there is no estimate), because the spend prompt on the confirmed call carries the charge. It skips the question only if the user already said any live model will do, or set a standing approval earlier in the conversation.Why: the old paragraph sent a prompt-only request straight to another provider's model without telling the user. That contradicts the same command's Step 0 rule (a suggestion from another provider is not a retry, so ask first). It also skipped Gemini's own text-to-video successor.
Step 0's first sentence already sends the three names to this paragraph, so it is unchanged.
Dated ids (
api_runway_gen4_turbo_image_to_video,api_google_gemini_omni_flash_1_1_t2v/_i2v,bfl/flux-3-video,veo/veo-3-t2v,kling/kling-v3-t2v,api_bfl_flux3_i2v) appear only as "as of 2026-09" examples. Next to them the paragraph tells the agent to use whatever the live search returns, following the README rule "Live specifics never freeze."Notes for reviewers
"video"" points to the task tags. "Don't quote a price" points to the spend prompt on the confirmed call. The paragraph contains no dead end.api_bfl_flux3_i2v.successor: true, media only,api_runway_gen4_turbo_image_to_video.successor: true, textapi_google_gemini_omni_flash_1_1_t2vand mediaapi_google_gemini_omni_flash_1_1_i2v.partner_generatequotes no estimate.Provenance
**Retiredlines byte-identical:diff <(grep '^\*\*Retired' skills/comfy-generate-video.md) <(grep '^\*\*Retired' claude-code/commands/generate-video.md)is emptyclaude plugin validate ./claude-code: passedsearch_templates, ComfyUI or "video"; none describe the old retired-model routing)Residual
search_templates/run_template/partner_generateagainst Comfy Cloud for the three retired names, so the live search results for "Runway Gen4", "Gemini Omni Flash" and "Flux 3 Video" with the task tags were not re-checked here. I checked the template ids and slugs against server source, not against a live catalog query. I also did not run the eval suite's retired partner-video bounce case against this text. Its pre-authorization clause is kept on purpose (see above).