Skip to content

Fix redstone dust transparent pixels rendered as reflective surface #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AzusaKe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix redstone dust transparent pixels rendered as reflective surface #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/dev/comfyfluffy/caustica/rt/terrain/RtTerrainMesher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import net.minecraft.tags.FluidTags;
import net.minecraft.util.RandomSource;
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.RedStoneWireBlock;
import net.minecraft.world.level.block.RenderShape;
import net.minecraft.world.level.block.state.BlockState;
import net.minecraft.world.level.material.FluidState;
Expand Down Expand Up @@ -440,6 +441,14 @@ private void putFabric(MutableQuadView quad) {
q.nx = nx; q.ny = ny; q.nz = nz;

ChunkSectionLayer layer = quad.chunkLayer();
// Minecraft 26.2 classifies redstone wire as TRANSLUCENT even though it is an alpha-tested
// cutout block (transparent background, opaque wire). Force it into the CUTOUT bucket so the
// any-hit shader can discard transparent pixels. Genuine translucent blocks (glass, ice) are
// unaffected — their TRANSLUCENT layer is correct.
if (layer == ChunkSectionLayer.TRANSLUCENT && state != null
&& state.getBlock() instanceof RedStoneWireBlock) {
layer = ChunkSectionLayer.CUTOUT;
}
q.cutout = layer != ChunkSectionLayer.SOLID;
q.translucent = layer == ChunkSectionLayer.TRANSLUCENT;

Expand Down
Loading