Fix RT resource lifetimes and shader payload UB - #26
Merged
Conversation
mif9499
added a commit
to mif9499/Caustica
that referenced
this pull request
Jul 25, 2026
xysgottaken2
added a commit
to xysgottaken2/Caustica
that referenced
this pull request
Sep 2, 2026
Cherry-picks upstream ddf36c0 "Prepare 0.1.1 release", the only commit on ComfyFluffy/Caustica's 0.1.x branch beyond its base. - gradle.properties: mod_version 0.1.0 -> 0.1.1 - lang: add debugView.8 "Emission Mask" / debugView.9 "Emission Source" across all 11 locales (en_us included for consistency; upstream's commit did not touch it since 0.1.x already carried those keys) Applied as a cherry-pick rather than a branch merge. upstream/0.1.x forked from 4a79795 on Jul 20 and does NOT contain the rendering and performance work this fork already has from upstream/main: 2cf7397 RIS emitter NEE with a spatial light grid (ComfyFluffy#23) f8714d7 Fix RT resource lifetimes and shader payload UB (ComfyFluffy#26) 47dd18e RT world path tracer: SER/payload/RIS perf pass (ComfyFluffy#27) 5d6bf62 Split ray tracing into wavefront passes (ComfyFluffy#29) Merging 0.1.x would have regressed those, plus fork-local features (SSS, weather lighting, denoiser toggle, hand FOV, tonemapping). Lang conflicts were resolved to keep both sides. Note: debugView.8/.9 are currently unused strings - the wavefront-split renderer exposes debug views 0-7 only. CI workflow untouched. No rendering logic ported or rewritten. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
xysgottaken2
added a commit
to xysgottaken2/Caustica
that referenced
this pull request
Sep 2, 2026
…stingcasutica fix: ray-traced rain (vanilla geometry) + Overworld distance/rain/night fog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GraphicsUse/TrackedGraphicsUsemodel for publication, reusable rings, and retirement[0, 1)Lifetime model
RtCompositereserves one graphics-use token before recording RT work and signals it after the world-overlay command buffer, the frame's final TLAS consumerRing depths (
4or6) are now latency/capacity choices rather than correctness horizons.Shader fixes
Payloadstructure in raygen, any-hit, and miss stages reachable by the traceVisibilityResult { transmittance, waterHitT }values from shadow traversal1.0Simplification
Non-goals
RtBuffergeneration poisoning or raw-handle use-after-free instrumentationTesting
.\gradlew.bat check compileShaders