Skip to content

add bounded retry-with-backoff to Soroban read calls#531

Merged
1nonlypiece merged 4 commits into
Commitlabs-Org:masterfrom
adelekevictor12:feature/contracts-read-retry-backoff
May 28, 2026
Merged

add bounded retry-with-backoff to Soroban read calls#531
1nonlypiece merged 4 commits into
Commitlabs-Org:masterfrom
adelekevictor12:feature/contracts-read-retry-backoff

Conversation

@adelekevictor12
Copy link
Copy Markdown
Contributor

closes #436

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

@adelekevictor12 is attempting to deploy a commit to the 1nonly's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 27, 2026

@adelekevictor12 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@adelekevictor12
Copy link
Copy Markdown
Contributor Author

The Vitest Coverage check is failing on 18 pre-existing test failures in 5 files I didn't touch:

  • tests/api/marketplace-cache-invalidation.test.ts (9 failures) — CacheKey.marketplaceStats is not defined
  • tests/api/etag.test.ts (2 failures) — uses non-existent toStartWith Chai property, and a property-order assertion mismatch
  • tests/api/user-preferences.test.ts (3 failures) — notification merge logic
  • tests/lib/backend/contracts.timeout.test.ts (3 failures) — tests hang for 5s and time out
  • tests/lib/backend/contracts_versioning.test.ts (1 failure) — expects contractVersion: 'v2'

These all fail on master as well (verified locally by running pnpm test on a clean checkout). My diff doesn't touch any of those files.

My 25 new tests in tests/api/contracts.service.retry.test.ts all pass. Happy to discuss whether to merge despite the red check or wait until those pre-existing failures are addressed by their owners.

@1nonlypiece 1nonlypiece merged commit b8c685c into Commitlabs-Org:master May 28, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backend - Add retry-with-backoff wrapper around Soroban read calls in contracts service

2 participants