feat: add persistent storage TTL bumps for commitments#552
Open
Dayz-tech-co wants to merge 3 commits into
Open
feat: add persistent storage TTL bumps for commitments#552Dayz-tech-co wants to merge 3 commits into
Dayz-tech-co wants to merge 3 commits into
Conversation
|
@Dayz-tech-co is attempting to deploy a commit to the 1nonly's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Dayz-tech-co Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #468
#468
This PR adds persistent-storage TTL management for escrow commitments so active commitment records and owner indexes remain readable through their full maturity window.
What changed
Added maturity-based TTL bump helpers in
contracts/escrow/src/lib.rsUpdated persistent write paths
savenow bumpsDataKey::Commitment(id)after each create/mutation writeindex_ownerrecomputes the latest maturity in an owner’s commitment list and bumpsDataKey::OwnerIndex(owner)deindex_ownerrefreshes the remaining owner index TTL after ownership changesAdded focused contract tests in
contracts/escrow/src/test.rsDocumented the strategy in
contracts/README.mdWhy
The escrow contract stores commitments in persistent Soroban storage, but without explicit TTL extension long-duration commitments can expire before they mature. This PR keeps active entries alive for the full escrow duration while avoiding unnecessary rent-extension fees.
Validation
Ran:
cargo check --lib --manifest-path contracts/Cargo.tomlcargo test ttl_ --manifest-path contracts/Cargo.tomlResult:
Notes